Skip to content

Gap-11: Functions Observe (B → A) — Invocation tracing + KQL query library - #1643

Open
paulyuk wants to merge 6 commits into
mainfrom
pass-equity-gap-11
Open

Gap-11: Functions Observe (B → A) — Invocation tracing + KQL query library#1643
paulyuk wants to merge 6 commits into
mainfrom
pass-equity-gap-11

Conversation

@paulyuk

@paulyuk paulyuk commented Apr 1, 2026

Copy link
Copy Markdown
Member

Closes #1619 | Parent: #1608

1 file: functions.md — FunctionAppLogs analysis, invocation-level tracing, Durable monitoring, 5 KQL queries (error rate, duration percentiles, cold starts), hosting plan sampling impact.

Starting assessment — domain experts should review.

Closes #1619 | Parent: #1608
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@paulyuk
paulyuk requested a review from JasonYeMSFT as a code owner April 1, 2026 17:37
Copilot AI review requested due to automatic review settings April 1, 2026 17:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Azure Functions observability reference focused on Application Insights, including invocation correlation concepts, Durable Functions telemetry notes, and a small KQL “query library” for common analyses.

Changes:

  • Documented built-in Application Insights integration and the FunctionAppLogs table schema.
  • Added guidance on invocation-level correlation (InvocationId/OperationId) and Durable Functions monitoring.
  • Included 5 KQL examples plus notes on hosting plan sampling impacts and configuration.

Comment thread plugin/skills/appinsights-instrumentation/references/functions.md Outdated
Comment thread plugin/skills/appinsights-instrumentation/references/functions.md Outdated
Comment thread plugin/skills/appinsights-instrumentation/references/functions.md Outdated
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor
Details# 🔍 Token Analysis Report

@github-copilot-for-azure/scripts@1.0.0 tokens
node --import tsx src/tokens/cli.ts compare --base origin/main --head HEAD --markdown

fatal: path 'plugin/skills/appinsights-instrumentation/references/functions.md' exists on disk, but not in 'origin/main'

📊 Token Change Report

Comparing origin/mainHEAD

Summary

Metric Value
📈 Total Change +556 tokens (+59%)
Before 937 tokens
After 1,493 tokens
Files Changed 2

Changed Files

File Before After Change
plugin/skills/appinsights-instrumentation/references/functions.md - 979 +979
plugin/skills/appinsights-instrumentation/SKILL.md 937 514 -423 (-45%)

@github-copilot-for-azure/scripts@1.0.0 tokens
node --import tsx src/tokens/cli.ts check --markdown

📊 Token Limit Check Report

Checked: 726 files
Exceeded: 100 files

⚠️ Files Exceeding Token Limits

File Tokens Limit Over By
.github/skills/analyze-skill-issues/SKILL.md 2109 500 +1609
.github/skills/analyze-test-run/SKILL.md 2471 500 +1971
.github/skills/file-test-bug/SKILL.md 628 500 +128
.github/skills/sensei/SKILL.md 856 500 +356
.github/skills/skill-authoring/SKILL.md 839 500 +339
.github/skills/vally-eval/SKILL.md 1757 500 +1257
plugin/skills/airunway-aks-setup/SKILL.md 1025 500 +525
plugin/skills/appinsights-instrumentation/SKILL.md 514 500 +14
plugin/skills/azure-ai/SKILL.md 820 500 +320
plugin/skills/azure-aigateway/SKILL.md 1261 500 +761
plugin/skills/azure-aigateway/references/policies.md 2342 2000 +342
plugin/skills/azure-cloud-migrate/SKILL.md 1085 500 +585
plugin/skills/azure-cloud-migrate/references/services/container-apps/cloudrun-deployment-guide.md 2029 2000 +29
plugin/skills/azure-cloud-migrate/references/services/container-apps/deployment-guide.md 2458 2000 +458
plugin/skills/azure-cloud-migrate/references/services/container-apps/fargate-deployment-guide.md 2587 2000 +587
plugin/skills/azure-cloud-migrate/references/services/container-apps/spring-deployment-guide.md 3871 2000 +1871
plugin/skills/azure-cloud-migrate/references/services/functions/lambda-to-functions.md 2600 2000 +600
plugin/skills/azure-cloud-migrate/references/services/functions/runtimes/javascript.md 2181 2000 +181
plugin/skills/azure-compliance/SKILL.md 1188 500 +688
plugin/skills/azure-compute/SKILL.md 762 500 +262
plugin/skills/azure-compute/workflows/essential-machine-management/references/emm-enable-flow.md 2344 2000 +344
plugin/skills/azure-compute/workflows/vm-troubleshooter/vm-troubleshooter.md 2509 2000 +509
plugin/skills/azure-deploy/SKILL.md 1645 500 +1145
plugin/skills/azure-deploy/references/pre-deploy-checklist.md 4692 2000 +2692
plugin/skills/azure-deploy/references/recipes/azd/errors.md 4004 2000 +2004
plugin/skills/azure-deploy/references/troubleshooting.md 2038 2000 +38
plugin/skills/azure-diagnostics/SKILL.md 1423 500 +923
plugin/skills/azure-enterprise-infra-planner/SKILL.md 911 500 +411
plugin/skills/azure-enterprise-infra-planner/references/constraints/compute-apps.md 2022 2000 +22
plugin/skills/azure-kubernetes/SKILL.md 2634 500 +2134
plugin/skills/azure-kubernetes/azure-kubernetes-automatic-readiness/SKILL.md 3690 500 +3190
plugin/skills/azure-kusto/SKILL.md 2152 500 +1652
plugin/skills/azure-messaging/SKILL.md 821 500 +321
plugin/skills/azure-prepare/SKILL.md 3145 500 +2645
plugin/skills/azure-prepare/references/aspire.md 4617 2000 +2617
plugin/skills/azure-prepare/references/plan-template.md 2560 2000 +560
plugin/skills/azure-prepare/references/recipes/azd/aspire.md 2275 2000 +275
plugin/skills/azure-prepare/references/recipes/azd/terraform.md 3555 2000 +1555
plugin/skills/azure-prepare/references/research.md 2196 2000 +196
plugin/skills/azure-prepare/references/resources-limits-quotas.md 3322 2000 +1322
plugin/skills/azure-prepare/references/security.md 2147 2000 +147
plugin/skills/azure-prepare/references/services/functions/bicep.md 3043 2000 +1043
plugin/skills/azure-prepare/references/services/functions/templates/recipes/composition.md 2813 2000 +813
plugin/skills/azure-prepare/references/services/functions/terraform.md 3404 2000 +1404
plugin/skills/azure-quotas/SKILL.md 3006 500 +2506
plugin/skills/azure-quotas/references/commands.md 2644 2000 +644
plugin/skills/azure-reliability/SKILL.md 5922 500 +5422
plugin/skills/azure-reliability/references/configure-multi-region.md 4729 2000 +2729
plugin/skills/azure-reliability/references/services/app-service/reliability.md 2591 2000 +591
plugin/skills/azure-resource-lookup/SKILL.md 1367 500 +867
plugin/skills/azure-resource-visualizer/SKILL.md 2122 500 +1622
plugin/skills/azure-storage/SKILL.md 1228 500 +728
plugin/skills/azure-upgrade/SKILL.md 1542 500 +1042
plugin/skills/azure-upgrade/references/languages/java/INSTRUCTION.md 2893 2000 +893
plugin/skills/azure-upgrade/references/languages/java/package-specific/com.microsoft.azure.management.md 2428 2000 +428
plugin/skills/azure-upgrade/references/languages/java/templates/PLAN_TEMPLATE.md 2411 2000 +411
plugin/skills/azure-upgrade/references/languages/java/templates/PROGRESS_TEMPLATE.md 2315 2000 +315
plugin/skills/azure-upgrade/references/languages/java/templates/SUMMARY_TEMPLATE.md 2190 2000 +190
plugin/skills/azure-upgrade/references/services/functions/automation.md 3463 2000 +1463
plugin/skills/azure-upgrade/references/services/functions/consumption-to-flex.md 2773 2000 +773
plugin/skills/azure-validate/SKILL.md 950 500 +450
plugin/skills/entra-agent-id/SKILL.md 3994 500 +3494
plugin/skills/entra-app-registration/SKILL.md 2058 500 +1558
plugin/skills/entra-app-registration/references/api-permissions.md 2545 2000 +545
plugin/skills/entra-app-registration/references/cli-commands.md 2211 2000 +211
plugin/skills/entra-app-registration/references/console-app-example.md 2752 2000 +752
plugin/skills/entra-app-registration/references/oauth-flows.md 2375 2000 +375
plugin/skills/microsoft-foundry/SKILL.md 6166 500 +5666
plugin/skills/microsoft-foundry/finetuning/SKILL.md 1375 500 +875
plugin/skills/microsoft-foundry/foundry-agent/azd-guidance/references/azd-ai-cli.md 2129 2000 +129
plugin/skills/microsoft-foundry/foundry-agent/create/create-hosted.md 7101 2000 +5101
plugin/skills/microsoft-foundry/foundry-agent/create/quick-start-hosted.md 5246 2000 +3246
plugin/skills/microsoft-foundry/foundry-agent/create/references/foundry-tool-catalog.md 10891 2000 +8891
plugin/skills/microsoft-foundry/foundry-agent/create/references/local-run.md 2252 2000 +252
plugin/skills/microsoft-foundry/foundry-agent/create/references/toolbox-reference.md 3137 2000 +1137
plugin/skills/microsoft-foundry/foundry-agent/create/references/tools.md 2359 2000 +359
plugin/skills/microsoft-foundry/foundry-agent/create/references/use-toolbox-in-hosted-agent.md 4288 2000 +2288
plugin/skills/microsoft-foundry/foundry-agent/deploy/deploy.md 4897 2000 +2897
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/eval-datasets.md 2863 2000 +863
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/references/generate-seed-dataset.md 2212 2000 +212
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/references/trace-to-dataset.md 4325 2000 +2325
plugin/skills/microsoft-foundry/foundry-agent/invocations-ws/invocations-ws.md 2652 2000 +652
plugin/skills/microsoft-foundry/foundry-agent/observe/observe.md 3856 2000 +1856
plugin/skills/microsoft-foundry/foundry-agent/observe/references/continuous-eval.md 3855 2000 +1855
plugin/skills/microsoft-foundry/foundry-agent/observe/references/evaluate-step.md 2175 2000 +175
plugin/skills/microsoft-foundry/foundry-agent/observe/references/evaluation-suite-generation.md 3134 2000 +1134
plugin/skills/microsoft-foundry/foundry-agent/routine/routine.md 2032 2000 +32
plugin/skills/microsoft-foundry/foundry-agent/trace/references/kql-templates.md 2701 2000 +701
plugin/skills/microsoft-foundry/models/deploy-model/SKILL.md 1805 500 +1305
plugin/skills/microsoft-foundry/models/deploy-model/capacity/SKILL.md 1739 500 +1239
plugin/skills/microsoft-foundry/models/deploy-model/customize/SKILL.md 2235 500 +1735
plugin/skills/microsoft-foundry/models/deploy-model/customize/references/customize-workflow.md 3335 2000 +1335
plugin/skills/microsoft-foundry/models/deploy-model/preset/SKILL.md 1226 500 +726
plugin/skills/microsoft-foundry/models/deploy-model/preset/references/preset-workflow.md 5534 2000 +3534
plugin/skills/microsoft-foundry/project/create/create-foundry-project.md 2283 2000 +283
plugin/skills/microsoft-foundry/quota/quota.md 2288 2000 +288
plugin/skills/microsoft-foundry/quota/references/capacity-planning.md 2080 2000 +80
plugin/skills/microsoft-foundry/references/agent-metadata-contract.md 2217 2000 +217
plugin/skills/microsoft-foundry/references/sdk/foundry-sdk-py.md 2162 2000 +162
plugin/skills/python-appservice-deploy/SKILL.md 688 500 +188

Consider moving content to references/ subdirectories.


Automated token analysis. See skill authoring guidelines for best practices.

@jongio jongio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two CI checks are failing:

  1. metadata.version in SKILL.md needs a bump (1.0.2 -> 1.0.3).
  2. functions.md isn't linked from SKILL.md - that's the orphaned file check. Add a link in the Guidelines section alongside the ASP.NET/Node.js/Python refs, and add Azure Functions app to Prerequisites.

Also flagged a couple of KQL issues inline - the ExceptionDetails column doesn't exist in FunctionAppLogs, and the Durable Functions query relies on name prefixes that aren't guaranteed.

Comment thread plugin/skills/appinsights-instrumentation/references/functions.md Outdated
Comment thread plugin/skills/appinsights-instrumentation/references/functions.md
Comment thread plugin/skills/appinsights-instrumentation/references/functions.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically closed because it has unresolved review comments and no new commits in the last 28 days.

If you would still like to merge these changes, please:

  1. Resolve all outstanding review comments
  2. Reopen this PR

Thank you for your contribution!

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@paulyuk paulyuk reopened this Jul 4, 2026
@paulyuk
paulyuk requested a review from RickWinter as a code owner July 4, 2026 19:05
@paulyuk

paulyuk commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Reopened and pushed 07ca93d addressing all outstanding review comments on this PR. Every unresolved thread has been resolved. Validators run locally: frontmatter and references pass, targeted skill tests pass, and the changed files are within token budget (the repo-wide tokens check failures are pre-existing baseline overages on unrelated files, not introduced here). Ready for another look — Gap-11 Functions Observe.

@paulyuk paulyuk closed this Jul 4, 2026
@paulyuk paulyuk reopened this Jul 4, 2026
@paulyuk
paulyuk force-pushed the pass-equity-gap-11 branch from 8eba5ea to 07ca93d Compare July 4, 2026 19:19

@jongio jongio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior feedback addressed: ExceptionDetails column dropped, FunctionAppLogs availability caveat added, Durable prefix warning included, and functions.md is now linked from SKILL.md. The correlation ID clarifications look correct.

One remaining item: metadata.version is set to "1.0.2" but skills under plugin/ should use "0.0.0-placeholder" in source (NBGV stamps the real version at build time). See .github/instructions/skill-files.instructions.md line 28. I was wrong in my previous review when I suggested bumping to 1.0.3; the correct value is the placeholder.

# Conflicts:
#	tests/appinsights-instrumentation/__snapshots__/triggers.test.ts.snap

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@jongio jongio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All prior feedback addressed: ExceptionDetails column removed, FunctionAppLogs availability caveat added, Durable prefix warning included, functions.md linked from SKILL.md, and version set to "0.0.0-placeholder" per repo convention.

Two minor test coverage gaps noted inline.

Comment thread tests/appinsights-instrumentation/triggers.test.ts Outdated
Comment thread scripts/src/frontmatter/cli.ts
…dator test

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@paulyuk

paulyuk commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Note on the red eval check: it's a pre-existing main-branch failure, not from this PR. vally's --strict orphan-files walk flags four azure-compute/references/* files that are only reached via ../../references/ links it doesn't follow. Fixed separately in #2744 so this PR stays in-scope. Every other check is green.

@paulyuk

paulyuk commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Hi @jongio, back after the July 4th weekend on the first business day. This one is ready for re-review. All of your earlier comments are addressed and the threads are resolved, so could you re-review and dismiss the stale changes-requested? The only red check is the pre-existing repo-wide eval failure, which #2744 fixes. Thanks!

Comment thread tests/appinsights-instrumentation/__snapshots__/triggers.test.ts.snap Outdated
Comment thread scripts/src/frontmatter/cli.ts Outdated
@paulyuk

paulyuk commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Hi @jongio and @JasonYeMSFT, first business day back after the July 4th weekend. I've addressed all your earlier comments and resolved the threads, so this is ready for a re-review. Could you take another pass and dismiss the stale changes-requested if it looks good? The only red check is the pre-existing repo-wide eval failure, already fixed on main by the vally 0.7.0 update (#2759), so it just needs a re-run to go green. Thanks!

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@paulyuk
paulyuk dismissed JasonYeMSFT’s stale review July 17, 2026 03:51

All requested changes are addressed. The legacy JavaScript tests and unrelated frontmatter validator changes were removed from this PR.

@paulyuk
paulyuk requested review from JasonYeMSFT and jongio July 17, 2026 03:53
@paulyuk

paulyuk commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

Hi @jongio, first business day back after July 4th. This one is ready for re-review. Everything you raised has been addressed and all threads are resolved, so could you re-review and dismiss the stale changes-requested? The only red check is the pre-existing repo-wide eval failure, unrelated to this PR. Thanks!

@paulyuk

paulyuk commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Hi @jongio, first business day back after the July 4th break. Everything you flagged is addressed and all threads are resolved, so this is ready for a re-review. When you get a moment, could you take another look and dismiss the stale changes-requested? The only red check is the pre-existing repo-wide eval failure, which is unrelated to these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gap-11: Functions Observe (B → A) — Invocation tracing, Durable monitoring, KQL library

4 participants