fix(develop): 17 corrections + orphan fix for PR #1636

plugin/skills/azure-prepare/SKILL.md

@@ -4,7 +4,7 @@ description: "Prepare Azure apps for deployment (infra Bicep/Terraform, azure.ya
 license: MIT
 metadata:
   author: Microsoft
-  version: "1.1.1"
+  version: "1.1.2"
 ---
 
 # Azure Prepare

plugin/skills/azure-prepare/references/analyze.md

@@ -97,4 +97,10 @@ Converting an existing application to run on Azure.
 
 > ⚠️ **Critical**: The Functions `bicep.md` and `terraform.md` files are **REFERENCE DOCUMENTATION**, not templates to copy. Hand-writing infrastructure from these patterns results in missing RBAC, incorrect managed identity configuration, and security vulnerabilities.
 
-For other compute targets (Container Apps, App Service, Static Web Apps), load their respective README files in `services/` for guidance.
+For **Container Apps**, load the composition rules the same way:
+
+1. Load `services/container-apps/templates/selection.md` — decision tree for base template + recipe
+2. Load `services/container-apps/templates/recipes/composition.md` — the exact algorithm to follow
+3. Use `azd init -t <template>` to generate proven IaC — **NEVER hand-write Bicep/Terraform**
+
+For other compute targets (App Service, Static Web Apps), load their respective README files in `services/` for guidance.

plugin/skills/azure-prepare/references/research.md

@@ -59,6 +59,8 @@ For each selected service, load the README.md first, then load specific files as
 Selected: Container Apps, Cosmos DB, Key Vault
 
 → Load: services/container-apps/README.md (overview)
+  → If need templates: services/container-apps/templates/selection.md
+  → Follow: services/container-apps/templates/recipes/composition.md
   → If need Bicep: services/container-apps/bicep.md
   → If need scaling: services/container-apps/scaling.md
   → If need health probes: services/container-apps/health-probes.md
@@ -103,7 +105,7 @@ Add research findings to `.azure/deployment-plan.md` under a `## Research Summar
 
 ### Web Application + API + Database
 
-1. Load: [services/container-apps/README.md](services/container-apps/README.md) → [bicep.md](services/container-apps/bicep.md), [scaling.md](services/container-apps/scaling.md)
+1. Load: [services/container-apps/README.md](services/container-apps/README.md) → [templates/selection.md](services/container-apps/templates/selection.md), [bicep.md](services/container-apps/bicep.md), [scaling.md](services/container-apps/scaling.md)
 2. Load: [services/cosmos-db/README.md](services/cosmos-db/README.md) → [partitioning.md](services/cosmos-db/partitioning.md)
 3. Load: [services/key-vault/README.md](services/key-vault/README.md)
 4. Invoke: `azure-observability` (monitoring setup)

plugin/skills/azure-prepare/references/services/container-apps/README.md

@@ -38,6 +38,12 @@ services:
 | Background Worker | None | 0 (scale to zero) | Queue-based |
 | Web Application | External | 1 | HTTP-based |
 
+## Templates & Recipes
+
+- **[Selection Guide](templates/selection.md)** — Start here: decision tree for base template + recipe
+- **[Composition Algorithm](templates/recipes/composition.md)** — How to fetch and compose templates
+- [AZD Templates](templates/recipes/README.md) — Recipe overview
+
 ## References
 
 - [Bicep Patterns](bicep.md)

plugin/skills/azure-prepare/references/services/container-apps/templates/api.md

@@ -68,6 +68,7 @@ resource api 'Microsoft.App/containerApps@2024-03-01' = {
           allowedMethods: ['GET', 'POST', 'PUT', 'DELETE', 'OPTIONS']
           allowedHeaders: ['*']
         }
+        // ⚠️ Replace '*' with specific origins for production
       }
       registries: [
         {

plugin/skills/azure-prepare/references/services/container-apps/templates/functions-on-aca.md

@@ -109,6 +109,10 @@ resource funcApp 'Microsoft.App/containerApps@2024-03-01' = {
               name: 'AzureWebJobsStorage__credential'
               value: 'managedidentity'
             }
+            {
+              name: 'AzureWebJobsStorage__clientId'
+              value: uamiClientId  // Required for UAMI — runtime defaults to system MI without this
+            }
             {
               name: 'FUNCTIONS_EXTENSION_VERSION'
               value: '~4'
@@ -155,6 +159,7 @@ scale: {
           namespace: 'my-sb-namespace'
           messageCount: '5'
         }
+        identity: userAssignedIdentityId
       }
     }
   ]

plugin/skills/azure-prepare/references/services/container-apps/templates/job.md

@@ -103,12 +103,22 @@ resource eventJob 'Microsoft.App/jobs@2024-03-01' = {
   name: '${name}-event'
   location: location
   tags: tags
+  identity: {
+    type: 'UserAssigned'
+    userAssignedIdentities: { '${userAssignedIdentityId}': {} }
+  }
   properties: {
     environmentId: envId
     configuration: {
       triggerType: 'Event'
       replicaTimeout: 600
       replicaRetryLimit: 2
+      registries: [
+        {
+          server: '${containerRegistryName}.azurecr.io'
+          identity: userAssignedIdentityId
+        }
+      ]
       eventTriggerConfig: {
         parallelism: 1
         replicaCompletionCount: 1

plugin/skills/azure-prepare/references/services/container-apps/templates/microservice.md

@@ -53,7 +53,10 @@ services:
 param name string
 param location string = resourceGroup().location
 param tags object = {}
+param logAnalyticsWorkspaceId string
+param logAnalyticsSharedKey string
 
+// logAnalytics resource must be declared or passed as parameter
 // Shared Container Apps Environment
 resource env 'Microsoft.App/managedEnvironments@2024-03-01' = {
   name: '${name}-env'
@@ -63,8 +66,8 @@ resource env 'Microsoft.App/managedEnvironments@2024-03-01' = {
     appLogsConfiguration: {
       destination: 'log-analytics'
       logAnalyticsConfiguration: {
-        customerId: logAnalytics.properties.customerId
-        sharedKey: logAnalytics.listKeys().primarySharedKey
+        customerId: logAnalyticsWorkspaceId
+        sharedKey: logAnalyticsSharedKey
       }
     }
   }

plugin/skills/azure-prepare/references/services/container-apps/templates/recipes/composition.md

@@ -49,7 +49,7 @@ IF recipes detected:
        name: name
        location: location
        tags: tags
-       containerAppPrincipalId: app.outputs.principalId
+       principalId: app.outputs.principalId
      }
    }
    ```
@@ -78,16 +78,13 @@ Read the recipe's `README.md` for required env vars. Add them to the container a
 Each recipe defines required RBAC roles. Use exact role definition GUIDs from recipe docs.
 
 ```bicep
-resource cosmosRbac 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
-  name: guid(cosmos.id, uami.id, cosmosDataContributor)
-  scope: cosmos
+resource cosmosRbac 'Microsoft.DocumentDB/databaseAccounts/sqlRoleAssignments@2024-05-15' = {
+  parent: cosmos
+  name: guid(cosmos.id, uami.id, 'data-contributor')
   properties: {
-    roleDefinitionId: subscriptionResourceId(
-      'Microsoft.Authorization/roleDefinitions',
-      '00000000-0000-0000-0000-000000000002'  // from recipe
-    )
+    roleDefinitionId: '${cosmos.id}/sqlRoleDefinitions/00000000-0000-0000-0000-000000000002'
     principalId: uami.outputs.principalId
-    principalType: 'ServicePrincipal'
+    scope: cosmos.id
   }
 }
 ```
@@ -132,7 +129,7 @@ Base (web-app)
 ## Critical Rules
 
 1. **Never synthesize IaC from scratch** — always extend base template
-2. **Never modify base IaC files** — only ADD recipe modules alongside them
+2. **Don't replace or remove base IaC resources** — extend base files only by adding module references and additive resources
 3. **Always use recipe RBAC role GUIDs** — never let the LLM guess role IDs
 4. **Always use UAMI** — never use connection strings or access keys
 5. **Always use `--no-prompt`** with azd commands

plugin/skills/azure-prepare/references/services/container-apps/templates/recipes/cosmos/README.md

@@ -24,7 +24,7 @@ resource cosmos 'Microsoft.DocumentDB/databaseAccounts@2024-05-15' = {
   kind: 'GlobalDocumentDB'
   properties: {
     databaseAccountOfferType: 'Standard'
-    disableLocalAuthentication: true
+    disableLocalAuth: true
     locations: [
       { locationName: location, failoverPriority: 0 }
     ]
@@ -101,4 +101,4 @@ const client = new CosmosClient({
 });
 ```
 
-> ⚠️ **Always set `disableLocalAuthentication: true`** — use RBAC only, never keys.
+> ⚠️ **Always set `disableLocalAuth: true`** — use RBAC only, never keys.

plugin/skills/azure-prepare/references/services/container-apps/templates/recipes/redis/README.md

@@ -35,14 +35,14 @@ resource redis 'Microsoft.Cache/redis@2024-03-01' = {
   }
 }
 
-// RBAC — Redis Cache Contributor
+// RBAC — Redis Cache Data Owner
 resource rbac 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
-  name: guid(redis.id, principalId, 'e0f68234-74aa-48ed-b826-c38b57376e17')
+  name: guid(redis.id, principalId, 'e12a10f1-dcd0-4ee7-abb0-0b2e24e345e7')
   scope: redis
   properties: {
     roleDefinitionId: subscriptionResourceId(
       'Microsoft.Authorization/roleDefinitions',
-      'e0f68234-74aa-48ed-b826-c38b57376e17'
+      'e12a10f1-dcd0-4ee7-abb0-0b2e24e345e7'
     )
     principalId: principalId
     principalType: 'ServicePrincipal'
@@ -67,8 +67,8 @@ env: [
 
 | Role | GUID | Access |
 |------|------|--------|
-| Redis Cache Contributor | `e0f68234-74aa-48ed-b826-c38b57376e17` | Manage cache + data |
-| Redis Cache Data Access | Custom role | Data plane operations |
+| Redis Cache Data Owner | `e12a10f1-dcd0-4ee7-abb0-0b2e24e345e7` | Read + write data |
+| Redis Cache Data Contributor | `e12a10f1-dcd0-4ee7-abb0-0b2e24e345c2` | Read-only data |
 
 ## SDK Connection (Node.js Example)
 
@@ -80,10 +80,16 @@ const credential = new DefaultAzureCredential({
   managedIdentityClientId: process.env.AZURE_CLIENT_ID,
 });
 
-const client = createClient({
-  url: `rediss://${process.env.REDIS_HOSTNAME}:${process.env.REDIS_PORT}`,
-  credential,
-});
+async function createRedisClient() {
+  const { token } = await credential.getToken("https://redis.azure.com/.default");
+  const client = createClient({
+    url: `rediss://${process.env.REDIS_HOSTNAME}:${process.env.REDIS_PORT}`,
+    username: process.env.AZURE_CLIENT_ID,
+    password: token,
+  });
+  await client.connect();
+  return client;
+}
 ```
 
 ## Dapr State Store
@@ -101,6 +107,7 @@ resource stateStore 'Microsoft.App/managedEnvironments/daprComponents@2024-03-01
       { name: 'redisHost', value: '${redis.outputs.hostName}:${redis.outputs.sslPort}' }
       { name: 'enableTLS', value: 'true' }
       { name: 'azureClientId', value: uamiClientId }
+      { name: 'useEntraID', value: 'true' }
     ]
   }
 }

plugin/skills/azure-prepare/references/services/container-apps/templates/recipes/servicebus/README.md

@@ -85,18 +85,15 @@ scale: {
           queueName: sb.outputs.queueName
           messageCount: '5'
         }
-        auth: [
-          {
-            secretRef: 'sb-identity'
-            triggerParameter: 'connection'
-          }
-        ]
+        identity: managedIdentityResourceId
       }
     }
   ]
 }
 ```
 
+> 💡 **Tip:** Set `identity` to the UAMI resource ID to authenticate the KEDA scaler via managed identity instead of connection strings.
+
 ## RBAC Roles
 
 | Role | GUID | Access |

plugin/skills/azure-prepare/references/services/container-apps/templates/worker.md

@@ -46,6 +46,7 @@ param envId string
 param containerRegistryName string
 param imageName string
 param userAssignedIdentityId string
+param uamiClientId string
 param serviceBusNamespace string = ''
 param queueName string = ''
 
@@ -82,7 +83,7 @@ resource worker 'Microsoft.App/containerApps@2024-03-01' = {
             { name: 'QUEUE_NAME', value: queueName }
             {
               name: 'AZURE_CLIENT_ID'
-              value: '' // Set to UAMI client ID
+              value: uamiClientId
             }
           ]
         }
@@ -100,12 +101,7 @@ resource worker 'Microsoft.App/containerApps@2024-03-01' = {
                 queueName: queueName
                 messageCount: '5'
               }
-              auth: [
-                {
-                  secretRef: 'sb-connection'
-                  triggerParameter: 'connection'
-                }
-              ]
+              identity: userAssignedIdentityId
             }
           }
         ]
@@ -146,9 +142,12 @@ rules: [
     custom: {
       type: 'azure-eventhub'
       metadata: {
+        namespace: '<namespace>'
+        eventHubName: '<eventhub>'
         consumerGroup: '$Default'
         unprocessedEventThreshold: '64'
       }
+      identity: userAssignedIdentityId
     }
   }
 ]
@@ -163,9 +162,11 @@ rules: [
     custom: {
       type: 'azure-queue'
       metadata: {
+        accountName: '<storage-account>'
         queueName: '<queue>'
         queueLength: '5'
       }
+      identity: userAssignedIdentityId
     }
   }
 ]