Escape OData filter input in msbench eval metrics#2745
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the GET /api/msbench-eval-metrics Azure Function by escaping user-provided benchmark and model query parameters before embedding them into an OData filter, and by returning generic 500-level error payloads instead of raw exception messages.
Changes:
- Added
odataLiteral()helper to escape single quotes for OData string literals and applied it tobenchmark/modelfilter clauses. - Replaced
context.log(... err.message)withcontext.error(...)and changed client-facing 500 responses to generic error messages.
| }; | ||
| } catch (err: any) { | ||
| context.log("Error querying eval metrics:", err.message); | ||
| context.error("Error querying eval metrics:", err?.message ?? err); |
| }; | ||
| } catch (err: any) { | ||
| context.log("Error querying eval filters:", err.message); | ||
| context.error("Error querying eval filters:", err?.message ?? err); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmarkandmodelquery values inGET /api/msbench-eval-metricswith the existing OData literal pattern ('->'') to prevent broken queries from malformed values.dashboard/api/src/functions/getMsbenchEvalMetrics.ts.context.error.Testing