feat: link skill dashboard pages to telemetry - #2874
Conversation
Add a 'View telemetry' link to each skill detail page in the Skills dashboard that opens the corresponding Azure Data Explorer telemetry view for the selected skill. Fixes microsoft#2871 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61579e26-24b2-4780-a2f7-f81c6311d777
There was a problem hiding this comment.
Pull request overview
Adds a “View telemetry ↗” outbound link to each skill’s detail header in the dashboard, pointing to the Azure Data Explorer telemetry dashboard for the selected skill (per Issue #2871).
Changes:
- Added an exported
telemetryUrl(skillName)helper to build the ADX dashboard URL and rendered a link in the skill detail header. - Added CSS styling for the telemetry link.
- Added unit tests validating the URL builder behavior.
Show a summary per file
| File | Description |
|---|---|
| dashboard/src/skills/App.tsx | Introduces telemetryUrl() and renders the “View telemetry” link for the selected skill (opens in new tab with noopener noreferrer). |
| dashboard/src/skills/skills.css | Adds styling for the telemetry link and spacing in the header. |
| dashboard/src/skills/tests/telemetryUrl.test.ts | Adds unit tests for the URL builder (currently includes one brittle full-string assertion). |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Low
JasonYeMSFT
left a comment
JasonYeMSFT
left a comment
There was a problem hiding this comment.
Reminder that our skills dashboard is technically speaking public. Are we ok with making the telemetry results publicly available? I haven't looked into how the kusto auth works. If it has another layer that guarantees only we can see the data that would be fine.
The dashboard is public, but this just links to the associated telemetry page rather than incorporating telemetry directly into the dashboard. The telemetry page has its own permissions. |
…s-fiesta # Conflicts: # dashboard/src/skills/App.tsx # dashboard/src/skills/skills.css
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61579e26-24b2-4780-a2f7-f81c6311d777
|
@JasonYeMSFT Good question. This PR only adds an outbound hyperlink to the ADX dashboard — it doesn't embed or expose any telemetry data in the (public) skills dashboard itself. The link points at dataexplorer.azure.com, which requires Azure AD sign-in, and the viewer must have read permission on the underlying Kusto cluster/database to see any results. So an anonymous visitor who clicks it just hits the ADX auth wall; no data is made public by this change. If you'd prefer we still gate the link's visibility (e.g., only render it in non-public deployments), I'm happy to add that — let me know. |
Fixes #2871
Summary
Adds a View telemetry ↗ link to each skill's detail page in the Skills section of the dashboard. The link opens the corresponding Azure Data Explorer telemetry view for the selected skill, using the URL form specified in the issue:
Changes
dashboard/src/skills/App.tsx— new exportedtelemetryUrl(skillName)helper and a telemetry link rendered in the skill detail header (opens in a new tab,rel="noopener noreferrer").dashboard/src/skills/skills.css— styling for the link.dashboard/src/skills/__tests__/telemetryUrl.test.ts— unit tests for the URL builder.Validation
vitestpasses (16 tests, including 2 new).tsc --noEmitis clean for the changed files (only a pre-existing, unrelated error remains intoken-usage/App.tsx).