feature: comparison integration tests - #2964
Closed
JasonYeMSFT (JasonYeMSFT) wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for running Vally-based integration tests across multiple configurations, specifically allowing comparisons across different models and with/without skills enabled via environment-variable overrides.
Changes:
- Added
MODEL_OVERRIDEsupport so the test runner can force a specific model during agent runs. - Added
--compare/--compare-optionsCLI support to run multiple Vally trials with different configurations. - Improved test reporting metadata when skills are disabled (
NO_SKILLS=true).
Show a summary per file
| File | Description |
|---|---|
| tests/vally/vally-executor.ts | Adds support for overriding the model via MODEL_OVERRIDE. |
| tests/utils/agent-runner.ts | Prioritizes MODEL_OVERRIDE and annotates reports when NO_SKILLS=true. |
| tests/run-vally-test.ts | Adds compare-mode CLI options and passes env overrides down to Vally runs. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Low
JasonYeMSFT (JasonYeMSFT)
force-pushed
the
chuye/no-skill-compare
branch
from
August 5, 2026 21:41
a0716c0 to
6845889
Compare
JasonYeMSFT (JasonYeMSFT)
force-pushed
the
chuye/no-skill-compare
branch
from
August 6, 2026 21:18
6845889 to
2c13694
Compare
JasonYeMSFT (JasonYeMSFT)
marked this pull request as draft
August 6, 2026 21:19
JasonYeMSFT (JasonYeMSFT)
marked this pull request as ready for review
August 7, 2026 18:11
JasonYeMSFT (JasonYeMSFT)
marked this pull request as draft
August 7, 2026 18:11
Member
Author
|
Replaced by #3070 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support running integration tests against different model + with/without skill configurations.
Checklist
cd tests && npm test)fix:,feat:,feature:,chore:,misc:,test:,eval:tests/,npm run test:integration -- <skill>ornpm run test:vally -- --skill <skill>)Related Issues
#2691 need the comparison result to determine if it can be removed.