eval: add max turn limit for foundry skill e2e - #3060
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Microsoft Foundry E2E eval scenarios to bound agent execution time and to run against a different Azure region, aiming to improve evaluation reliability and cost control for the Foundry skill end-to-end tests.
Changes:
- Added per-stimulus
constraints.max_turnslimits for two Foundry E2E scenarios. - Switched the “Region” specified in both scenario prompts from “North Central US” to
eastus2.
Suppressed comments (1)
evals/azure-skills/microsoft-foundry/eval.yaml:537
- This scenario also pins the Foundry region to
eastus2, which appears to conflict with the microsoft-foundry skill documentation that says hosted agents (preview) require North Central US (plugins/azure-skills/skills/microsoft-foundry/project/create/create-foundry-project.md:138-153). If the requirement changed, consider updating the docs in the same PR; otherwise this eval may fail due to unsupported region.
Region: eastus2
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Xiaofu Huang (XiaofuHuang)
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
cd tests && npm test)fix:,feat:,feature:,chore:,misc:,test:,eval:tests/,npm run test:integration -- <skill>ornpm run test:vally -- --skill <skill>)Related Issues