Add nuget.config with nuget.org package source#100
Closed
tomer-w wants to merge 1 commit into
Closed
Conversation
Ensures all contributors have the correct NuGet package source configured without relying on machine-level settings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make restores/builds deterministic by adding a repository-level nuget.config that defines the NuGet package sources needed to build the server project without relying on machine-level configuration.
Changes:
- Adds a new repo-level
nuget.config. - Clears any machine/user-defined package sources and configures a single package source entry.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <?xml version="1.0" encoding="utf-8"?> | ||
| <configuration> | ||
| <packageSources> | ||
| <clear /> |
| <configuration> | ||
| <packageSources> | ||
| <clear /> | ||
| <add key="Microsoft Visual Studio Offline Packages" value="C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building the server project (\src/Server) fails on machines where nuget.org is not configured as a machine-level NuGet package source, since packages like \Microsoft.Azure.Kusto.Data\ and \StreamJsonRpc\ cannot be found.
Solution
Add a repo-level
uget.config\ that explicitly configures nuget.org as the package source. Uses <clear />\ to ensure a clean, predictable set of sources regardless of machine configuration.
Validation