Skip to content

Add query execution indicators#103

Merged
mattwar merged 7 commits into
mainfrom
user/danieldror/query_execution_indicator
May 6, 2026
Merged

Add query execution indicators#103
mattwar merged 7 commits into
mainfrom
user/danieldror/query_execution_indicator

Conversation

@danield137

Copy link
Copy Markdown
Contributor

Shows a native running indicator while Kusto queries execute.

Also adds last-run details to the query CodeLens: run time, duration, and a copyable client request ID.

Validation: npm run lint/test/compile, dotnet build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 5, 2026 22:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds end-to-end support for query execution UX improvements in the VS Code extension: a native “running” indicator while queries execute, plus richer “last run” metadata (timestamp, duration, and client request ID) surfaced via CodeLens and persisted in history. It also wires a clientRequestId through the client → language server → Kusto connection stack so executions can be correlated.

Changes:

  • Add query-running UI state (editor title command + CodeLens “Running” + status bar item + progress notification) driven by a new msKustoExplorer.queryRunning context key.
  • Persist and display last-run details (started-at timestamp, client-measured duration, and client request ID), including a “Copy CID” CodeLens action.
  • Plumb optional clientRequestId from the client LSP request through server query execution to Kusto ClientRequestProperties.ClientRequestId.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ServerTests/Features/ServerSchemaSourceTests.cs Updates test IConnection.ExecuteAsync stub signature to include clientRequestId.
src/Server/Server.cs Extends kusto/runQuery params with clientRequestId and forwards it to IQueryManager.
src/Server/Querying/QueryManager.cs Adds clientRequestId to query execution context and forwards it to IConnection.ExecuteAsync.
src/Server/Querying/IQueryManager.cs Updates RunQueryAsync contract to accept clientRequestId.
src/Server/Connections/IConnection.cs Extends ExecuteAsync contract to accept optional clientRequestId.
src/Server/Connections/ConnectionManager.cs Applies clientRequestId onto Kusto ClientRequestProperties when provided.
src/Client/package.json Adds contributed “Running Query” command and swaps editor-title command based on msKustoExplorer.queryRunning.
src/Client/features/server.ts Extends LSP runQuery request to accept and send clientRequestId; adds new ResultData fields.
src/Client/features/queryEditor.ts Implements running indicator state machine + progress UI; captures/persists execution timing and CID; adds CodeLens for last-run details and copy CID.
src/Client/features/historyManager.ts Persists execution metadata into history index entries.
src/Client/extension.ts Registers new noop/copy commands used by CodeLens and editor-title running indicator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Client/features/queryEditor.ts Outdated
Comment thread src/Server/Querying/QueryManager.cs
@danield137 danield137 requested a review from mattwar May 5, 2026 22:34
danield137 and others added 2 commits May 5, 2026 15:41
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 5, 2026 22:45
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Client/features/queryEditor.ts Outdated
danield137 and others added 2 commits May 5, 2026 15:52
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 5, 2026 23:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mattwar
mattwar previously approved these changes May 5, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mattwar mattwar merged commit 1ae1610 into main May 6, 2026
5 checks passed
@mattwar mattwar deleted the user/danieldror/query_execution_indicator branch May 6, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants