Add support for new formatting options#105
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the formatting configuration surface area for the Kusto VS Code extension by introducing new spacing-related formatter settings, adding a legacy placement-style alias, and wiring these settings through the server options pipeline.
Changes:
- Added many new formatting spacing settings (single and dual-sided spacing) to both client configuration schema and server settings plumbing.
- Added support for legacy placement-style value
"none"as an alias (alongside"asIs"). - Updated
StringMappedSettingreverse-mapping behavior to allow multiple keys (aliases) to map to the same value, and added server-side tests for the new behaviors.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ServerTests/Features/OptionsManagerTests.cs | Adds tests for legacy placement aliases and new spacing settings propagation through OptionsManager. |
| src/Server/Settings/Setting.cs | Updates StringMappedSetting reverse map building to tolerate alias keys mapping to the same value. |
| src/Server/Settings/OptionsManager.cs | Wires new spacing-related settings into Kusto.Language.Editor.FormattingOptions construction. |
| src/Server/Settings/FormatSettings.cs | Defines new spacing settings (and their string mappings) and includes them in the server’s settings retrieval list. |
| src/Server/Server.csproj | Changes Kusto package references to floating versions (14.*, 12.*). |
| src/Client/package.json | Adds new configuration schema entries for formatting spacing options and updates placement-style enums/descriptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for new formatting options in kusto language library 12.4.0