Skip to content

Dont force sidebar open when history is added#108

Merged
mattwar merged 1 commit into
mainfrom
user/mattwar/GuardHistoryReveal
May 11, 2026
Merged

Dont force sidebar open when history is added#108
mattwar merged 1 commit into
mainfrom
user/mattwar/GuardHistoryReveal

Conversation

@mattwar

@mattwar mattwar commented May 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 11, 2026 18:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the History sidebar behavior to avoid unexpectedly opening the Kusto sidebar when query history is updated or when “Show Results” selects a matching history entry.

Changes:

  • Guarded TreeView.reveal() calls behind this.treeView.visible in the history-added event handler.
  • Guarded revealEntry() behind this.treeView.visible to avoid opening the sidebar as a side effect of “Show Results”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Client/features/historyPanel.ts
Comment thread src/Client/features/historyPanel.ts
Comment thread src/Client/features/historyPanel.ts
@mattwar mattwar merged commit 0466e45 into main May 11, 2026
9 checks passed
@mattwar mattwar deleted the user/mattwar/GuardHistoryReveal branch May 11, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants