Add graph chart #126
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Graph chart type to the VS Code extension’s results viewer, rendering node-link graphs via Cytoscape and introducing persisted per-chart presentation state (e.g., node positions / layout seed).
Changes:
- Server: emit chart descriptors for any primary-result statement with a
render, not just the main result. - Client: add
GraphChartProvider(Cytoscape-based) and routeChartType.Graphthrough the composite provider. - Client: add
ResultData.chartViews+ plumbing to persist per-chart view state, and extend the chart editor to support graph-specific options.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Server/Connections/ConnectionManager.cs | Builds chart descriptors from visualization options on each primary result table. |
| src/Server/Charting/ChartOptions.cs | Adds graph-specific chart options (nodes/edges table + column overrides) and merges defaults. |
| src/Client/features/server.ts | Extends result schema with chartViews and adds graph-specific option fields. |
| src/Client/features/resultsViewer.ts | Persists per-chart view state and passes cross-table context to chart renderers. |
| src/Client/features/graphChartProvider.ts | New Cytoscape-based graph renderer with optional persisted layout state. |
| src/Client/features/compositeChartProvider.ts | Delegates ChartType.Graph to the new graph provider and forwards view-state subscriptions. |
| src/Client/features/chartProvider.ts | Extends chart view interface to accept cross-table context + view state updates. |
| src/Client/features/chartEditorProvider.ts | Adds graph options UI and passes sibling-table metadata for nodes/edges selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GraphChartProvider that uses cytoscape to draw graphs.