Use simple-datatables for data grid control instead of detailed html …#39
Merged
Conversation
…table elements. Adds handling for large data sets, column ordering. Add ability to select row. Refactoring and cleanup within resultsViewer.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and renames several functions, commands, and context keys related to displaying Kusto query results and charts in the VS Code extension. The changes aim to clarify the distinction between results shown in a panel vs. a singleton (single-instance) view, improve naming consistency, and add a new search command for results views.
Key changes include:
Data Binding
Adds use of simple data grid control to avoid building large html tables for performance.
Refactoring and Renaming for Clarity:
resultsViewerand their usages throughout the codebase to distinguish between displaying results in a panel (displayResultsInPanel) and in a singleton view (displayResultsInSingletonView). Related error display functions were also renamed for clarity. [1] [2] [3] [4] [5] [6]Command and Menu Updates:
package.jsonto match the new naming convention, such askusto.saveChart→kusto.saveSingletonResults,kusto.saveResults→kusto.savePanelResults, andkusto.chartResults→kusto.chartPanelResults. [1] [2] [3] [4]viewTypefromkusto.resultEditortokusto.resultViewerfor consistency.Feature Addition:
kusto.toggleSearchcommand and corresponding menu entries to enable searching within results views. [1] [2] [3]These changes improve code readability, maintainability, and user experience by making the distinction between different result display modes clearer and by adding search functionality.