Add accumulate implementation and others#88
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for an accumulate data transform in chart rendering and evolves result payloads from a single chartOptions object to a charts[] list to enable future multi-chart support.
Changes:
- Replace
chartOptionswithcharts(list ofResultChart) across server DTOs, client types, viewers, and tests. - Implement
accumulatein Plotly chart building (applied after sorting, before downsampling; also works with binning and grouped series). - Enhance chart rendering/editing features and coverage (anomaly overlays refactor, area markers/value labels, y-axis mirroring behavior, updated editor labels).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Server/Utilities/ResultData.cs | Switches serialized result model from chartOptions to charts[] and introduces ResultChart. |
| src/Server/Connections/IConnection.cs | Updates ExecuteResult to carry Charts descriptors instead of a single ChartOptions. |
| src/Server/Connections/ConnectionManager.cs | Produces a single-item Charts list from Kusto visualization options. |
| src/Client/features/server.ts | Updates client-side ResultData contract to charts?: ResultChart[]. |
| src/Client/features/resultsViewer.ts | Adapts viewing/editing/persistence flows to operate on the “primary” chart in charts[]. |
| src/Client/features/plotlyChartProvider.ts | Adds accumulate implementation, improves markers/value labels for area/line, refactors anomaly overlays, and adjusts y-mirror handling. |
| src/Client/features/html.ts | Updates clipboard HTML conversion’s hasChart detection to use charts[]. |
| src/Client/features/chartEditorProvider.ts | Updates some chart editor field labels for clarity. |
| src/Client/tests/unit/plotlyChartProvider.test.ts | Adds tests for anomaly overlays, area markers/labels, accumulate behavior, and yMirror subplot behavior. |
| src/Client/tests/unit/html.test.ts | Updates hasChart tests to reflect charts[]. |
| src/Client/tests/integration/queryEditor.test.ts | Updates integration fixture/comments to use charts[]. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation for accumulate data transform in chart options
Change result storage format for future support of multiple charts