Change base ids for ui elements to not conflict with other extensions#91
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the extension’s contributed VS Code UI identifiers (views, view containers, and related drag-and-drop MIME types) to use a more unique msKustoExplorer-* prefix to reduce collisions with other extensions.
Changes:
- Renamed contributed view IDs / view container IDs in
package.jsonand updated relatedwhenclauses for menus and webview context menus. - Updated runtime registrations/usages to match the new view IDs (TreeViews and Results webview view provider/focus commands).
- Updated the Scratch Pad integration test to focus the renamed view.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Client/tests/integration/scratchPadPanel.test.ts | Updates the focus command to match the renamed Scratch Pads view ID. |
| src/Client/package.json | Renames view container + view IDs and updates menu/webview-context when clauses accordingly. |
| src/Client/features/scratchPadPanel.ts | Updates Scratch Pads TreeView ID and its drag-and-drop MIME type to match the new view ID. |
| src/Client/features/resultsViewer.ts | Updates panel Results view provider registration and focus commands to the renamed results view ID. |
| src/Client/features/historyPanel.ts | Updates History TreeView ID to the renamed view ID. |
| src/Client/features/connectionsPanel.ts | Updates Connections TreeView ID and drag-and-drop MIME types to match the renamed view ID. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…etted as subtraction in when clauses Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.