Improve result history entry labels to be more informative#92
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves the labels shown for query result history entries by deriving a human-friendly label from leading query comments when available, while retaining access to the server-minified query text for tooltips and hashing.
Changes:
- Add
computeHistoryDisplayLabel()and related helpers to derive informative history labels from leading comments with sensible fallbacks. - Store and surface an optional
minifiedPreviewfor tooltips, and reuse server-minified query text for hashing. - Add unit tests covering label derivation behaviors (decorative banners, whitespace, CRLF, truncation, fallbacks).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Client/features/historyManager.ts | Adds label computation logic, new minifiedPreview field, and refactors minified-query hashing/minified retrieval. |
| src/Client/features/historyPanel.ts | Updates tooltip to prefer minifiedPreview over the (now more “title-like”) queryPreview. |
| src/Client/tests/unit/historyManager.test.ts | Adds unit tests for computeHistoryDisplayLabel() behavior and edge cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.