Skip to content

Improve readme files.#95

Closed
tomer-w wants to merge 2 commits into
microsoft:mainfrom
tomer-w:main
Closed

Improve readme files.#95
tomer-w wants to merge 2 commits into
microsoft:mainfrom
tomer-w:main

Conversation

@tomer-w

@tomer-w tomer-w commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Move all internal implementation details to the contrbuting.md file.
Cross links to the marketplace.
general alignment.

Copilot AI review requested due to automatic review settings April 30, 2026 10:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s public-facing documentation to provide a clearer user guide, streamlined top-level README, and more complete contributor/developer instructions.

Changes:

  • Rewrote src/Client/README.md into a structured “Get Started” + “Features” user guide with updated links and requirements.
  • Refreshed the root README.md with badges, a concise feature list, install steps, and a pointer to the user guide.
  • Expanded CONTRIBUTING.md with repository structure, debugging, packaging, and manual install/uninstall instructions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Client/README.md Reorganized into a clearer end-user guide with steps, feature sections, and updated links/requirements.
README.md Simplified and modernized the main README with badges, feature highlights, install instructions, and a user guide link.
CONTRIBUTING.md Added repository structure and expanded development/debugging/packaging instructions for contributors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CONTRIBUTING.md Outdated
@tomer-w

tomer-w commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 30, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Client/README.md
## Query Editor (query set documents)

1. Select the **Kusto Explorer** icon in the VS Code Activity Bar
2. Open a scratch pad or create a `.kql` file

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scratch pad will already be open, so a better phrasing is "Use an existing scratch pad (already open) or create a '.kql' file."

Comment thread src/Client/README.md

1. Select the **Kusto Explorer** icon in the VS Code Activity Bar
2. Open a scratch pad or create a `.kql` file
3. Connect to a Kusto cluster and database:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording changes the meaning. You are not just connecting to a cluster and database; you are making an association between a document and a cluster/database. This is key, because you must make the connection panel selection while the query document has focus.

Comment thread README.md
Run `code --uninstall-extension Microsoft.kusto-explorer-vscode` on command line.
1. Open the **Kusto Explorer** icon in the VS Code Activity Bar
2. Add a cluster connection in the **Connections** sidebar
3. Select a database to set it as active for your query document

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have selected a query document first

@mattwar mattwar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes are fine, but some have changed meaning, making the instructions incorrect.

@tomer-w tomer-w closed this May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants