Add process for proposals#96
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a contribution workflow that routes larger or roadmap-impacting changes through a proposal/discussion process before opening PRs.
Changes:
- Expands CONTRIBUTING guidance to distinguish “small changes” vs “needs prior approval”.
- Introduces a proposal-first process via GitHub Discussions, including expected proposal contents and outcomes.
- Updates the PR checklist/process to reference the new discussion/proposal flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - A rough implementation approach, if relevant | ||
| - Alternatives you considered | ||
|
|
||
| When you believe the discussion is ready for formal consideration, add the `design review` label. That label means a design review is requested. It does not mean the proposal has been approved. |
There was a problem hiding this comment.
GitHub Discussions typically don’t support labels the same way Issues/PRs do (and contributors often can’t apply labels even where labels exist). Consider changing this to an actionable, platform-supported step (e.g., ‘comment to request design review’, ‘use a title prefix like [Design Review]’, or ‘open/convert to an issue and the team will apply the design review label’). The current instruction is likely not executable by contributors.
| When you believe the discussion is ready for formal consideration, add the `design review` label. That label means a design review is requested. It does not mean the proposal has been approved. | |
| When you believe the discussion is ready for formal consideration, comment on the discussion to request design review. You may also add a `[Design Review]` prefix to the discussion title to make the request clear. A design review request does not mean the proposal has been approved. |
| - Decide to implement it internally | ||
| - Mark it as open for a community contribution | ||
|
|
||
| When a design is under review a corresponding issue will be opened for it that will track the proposal's progress. |
There was a problem hiding this comment.
This sentence is missing punctuation that clarifies the clause boundary. Consider adding a comma after ‘under review’ to improve readability (e.g., ‘When a design is under review, a corresponding issue…’).
| When a design is under review a corresponding issue will be opened for it that will track the proposal's progress. | |
| When a design is under review, a corresponding issue will be opened for it that will track the proposal's progress. |
No description provided.