Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: primitive parsing for strings as DateTimes is too greedy #2160

Merged
merged 8 commits into from
Feb 26, 2025
Merged

fix: primitive parsing for strings as DateTimes is too greedy #2160

merged 8 commits into from
Feb 26, 2025

Conversation

MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Feb 20, 2025 •
edited
Loading

Fixes #2137

@MaggieKimani1 MaggieKimani1 marked this pull request as ready for review February 24, 2025 12:48
baywet
baywet approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@MaggieKimani1 MaggieKimani1 merged commit 4ee1d8b into main Feb 26, 2025
10 of 13 checks passed
@MaggieKimani1 MaggieKimani1 deleted the fix/primitive-parsing-bug branch February 26, 2025 14:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2 - Primitive parsing for strings as DateTimes is too greedy
2 participants
@MaggieKimani1 @baywet