Skip to content

fix: Validate schema property is not null #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025

Conversation

cliedeman
Copy link
Contributor

@cliedeman cliedeman commented Aug 18, 2025

Fixes microsoft/kiota#6846 throw error is schema property is null

@cliedeman cliedeman requested a review from a team as a code owner August 18, 2025 20:02
baywet
baywet previously approved these changes Aug 19, 2025
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@baywet
Copy link
Member

baywet commented Aug 19, 2025

@cliedeman with the other PR being merged first (#2459 ), the resource file is conflicting.
Can you please merge the changes? (the easiest is probably to accept all incoming changes, and then re-generate the designer file)

@cliedeman cliedeman force-pushed the feat/validate-null-property branch 2 times, most recently from ad500ce to 886afa1 Compare August 19, 2025 13:44
@cliedeman cliedeman requested a review from baywet August 19, 2025 13:45
@cliedeman
Copy link
Contributor Author

Thanks @baywet. Updated

@cliedeman cliedeman force-pushed the feat/validate-null-property branch 3 times, most recently from 2a60c79 to ae892d9 Compare August 19, 2025 13:50
@cliedeman cliedeman force-pushed the feat/validate-null-property branch from ae892d9 to 5c9817c Compare August 19, 2025 14:23
baywet
baywet previously approved these changes Aug 19, 2025
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge August 19, 2025 14:59
auto-merge was automatically disabled August 19, 2025 20:10

Head branch was pushed to by a user without write access

@cliedeman
Copy link
Contributor Author

Fixed tests

@cliedeman cliedeman requested a review from baywet August 19, 2025 20:12
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge (squash) August 20, 2025 12:44
@baywet baywet merged commit 3326022 into microsoft:main Aug 20, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The following schema causes null exception during generation
2 participants