[VCM] introduce EOL warning infobar #21474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htcfreek
reviewed
Oct 26, 2022
Co-authored-by: Heiko <[email protected]>
|
Hm, just yesterday I saw the issue and it gave me the idea that it was still debatable, but looks pretty definitive... |
niels9001
previously requested changes
Oct 27, 2022
Jay-o-Way
reviewed
Oct 27, 2022
Co-authored-by: Jay <[email protected]>
niels9001
reviewed
Oct 27, 2022
jaimecbernardo
approved these changes
Oct 27, 2022
|
Thanks for the help everyone! |
yuyoyuppe
dismissed
niels9001’s stale review
@niels9001 already fixed all his suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
"Learn more" is clickable and leads to the issue.
PR Checklist
Validation Steps Performed