MAINT: Simplifying Rapid Response and Cyber#2117
Merged
rlundeen2 merged 1 commit intoJul 2, 2026
Merged
Conversation
rlundeen2
force-pushed
the
rlundeen2-phase-c-simple-scenarios
branch
from
1bebf45 to
54e54c2
Compare
varunj-msft
approved these changes
Jul 2, 2026
Phase C: migrate the two simple scenarios (Cyber, RapidResponse) off the base-class default cross-product and onto composition via new shared helpers in matrix_atomic_attack_builder.py: - resolve_technique_factories(*, context): resolve selected strategies to registry factories, preserving order and dropping missing. - build_matrix_atomic_attacks(*, context, objective_scorer, display_group_fn): one-line technique x dataset matrix construction. Cyber and RapidResponse now override _build_atomic_attacks_async with a single call to the helper. AdversarialBenchmark reuses resolve_technique_factories to drop its inline factory-resolution block. Adds unit tests for both helpers; removes obsolete RapidResponse TestBuildDisplayGroup. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
rlundeen2
force-pushed
the
rlundeen2-phase-c-simple-scenarios
branch
from
54e54c2 to
f8f4f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Phase C of the scenario simplification effort (design gist): it migrates the two simple scenarios,
CyberandRapidResponse, off the inherited base-class default cross-product and onto composition. Both now override_build_atomic_attacks_asyncwith a single call to a new shared helper,build_matrix_atomic_attacks, backed byresolve_technique_factories(whichAdversarialBenchmarkalso reuses to drop its inline factory-resolution block). These free, opt-in helpers keep the baseScenariouncoupled from the matrix shape while avoiding per-scenario boilerplate, and unblock the base-default deletions planned for Phase D. Includes unit tests for both helpers and removes the now-obsoleteRapidResponsedisplay-group test.