fix(converter): Æ morse key has a stray leading space (KeyError)#2137
Merged
rlundeen2 merged 2 commits intoJul 8, 2026
Merged
Conversation
The extended morse map keyed Æ as " Æ" (leading space), so Æ was in supported_charset but missing from the lookup, making MorseConverter raise KeyError on any input containing æ/Æ. +regression tests. Signed-off-by: WatchTree-19 <119982314+WatchTree-19@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
rlundeen2
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
MorseConverterraisesKeyErroron any prompt containingæ/Æ:in the extended-character map the
Æentry is keyed" Æ"(stray leading space).supported_charsetis built by joining the mapping keys, so the' 'and'Æ'characters both land in it and"Æ" in supported_charsetisTrue- but the lookup dict only has the key" Æ", somorse_mapping["Æ"]raisesKeyError. the converter hardcodesextended_char_support=True, so it advertisesÆas supported.fix
key the entry
"Æ"(its morse.-.-is unchanged and matches the neighbouringÄ/Ą).test
added
test_morse_converter_extended_ae_ligature/..._in_word. both fail on main (KeyError), pass with the fix (æ->.-.-); fulltest_morse_converter.py8 pass, ruff clean.found by reading the converter.