[CI]: Improve CI and split out coverage as separate workflow#29
Merged
Conversation
Contributor
Author
|
Coverage still expected to fail here, but tests passing 3.11-13 😄 |
nina-msft
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separates coverage analysis from the CI test workflow into an independent
coverage.ymlworkflow, and applies several CI hardening improvements.Changes:
Split coverage into
coverage.yml: Coverage collection, reporting, and threshold enforcement now run in a dedicated workflow with a single Python 3.12 job, independent from the test matrix. This gives separate status checks in PRs —CIfor correctness,Coveragefor quality — enabling independent branch protection policies (e.g., requiring CI but making coverage advisory).Remove
--covfrom test workflow: Thetestjob inci.ymlnow runs plainpytestwithout coverage instrumentation, simplifying the job and slightly improving test performance.Add
needs: lintto test job: Tests now wait for lint to pass before running, avoiding wasted compute on 3 matrix jobs when the code doesn't lint.Add
timeout-minutes: 10to all jobs: Prevents hung jobs from consuming runners for the default 6-hour limit.Coverage Job Summary: The coverage workflow writes a markdown coverage table directly to the GitHub Actions Job Summary page, providing visibility without external services or artifact downloads.
Separated failure signals: Test failures and coverage threshold failures produce distinct step-level signals in the coverage workflow. The threshold is enforced via
pyproject.toml[tool.coverage.report] fail_under(DRY — single source of truth).Breaking changes
None. No changes to runtime code, test code, or pyproject.toml configuration. Branch protection rules may need updating to add the new
Coveragestatus check if desired.Checklist
pre-commit run --all-filespasses