Skip to content

[MAINT]: removing asyncio#36

Merged
rlundeen2 merged 3 commits into
microsoft:mainfrom
rlundeen2:users/rlundeen/2026_04_30_pyproject_update
Apr 30, 2026
Merged

[MAINT]: removing asyncio#36
rlundeen2 merged 3 commits into
microsoft:mainfrom
rlundeen2:users/rlundeen/2026_04_30_pyproject_update

Conversation

@rlundeen2

@rlundeen2 rlundeen2 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Remove all @pytest.mark.asyncio decorators from tests and drop the related instruction from unit test standards. The project uses asyncio_mode = "auto" (configured in pyproject.toml), which collects async tests automatically — making the decorators redundant.

@rlundeen2 rlundeen2 requested a review from a team April 30, 2026 18:36

@spencrr spencrr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your comment and mine - easy change to remove some boilerplate. LGTM! #35 (comment)

Comment thread .github/instructions/unit-tests-standards.instructions.md Outdated
@bashirpartovi

Copy link
Copy Markdown
Contributor

Thanks @rlundeen2 for this cleanup, makes total sense, just one request so we keep these PRs up to the standard, do you mind adding a short description to the PR ?

@rlundeen2 rlundeen2 changed the title [MAINT] removing asyncio MAINT: removing asyncio Apr 30, 2026
@rlundeen2 rlundeen2 changed the title MAINT: removing asyncio [MAINT]: removing asyncio Apr 30, 2026
@rlundeen2 rlundeen2 merged commit 096c19d into microsoft:main Apr 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants