Add support for type parameters for interfaces and nullable property #2288
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
inputfiles/patches/indexeddb.kdl
Outdated
| @@ -0,0 +1,5 @@ | |||
| interface IDBRequest { | |||
| property source nullable=#false | |||
There was a problem hiding this comment.
this should use type node instead
There was a problem hiding this comment.
I don't understand @saschanaz
Can you clarify?
This is how it is structured in the json file
There was a problem hiding this comment.
And not in KDL, because it's "property with a nullable type" rather than "nullable property"...
|
If you meant line 3 @saschanaz, then it doesn't work because it is not a known type |
|
The issue is that it is an empty string what do you want me to do @saschanaz
|
inputfiles/patches/indexeddb.kdl
Outdated
| interface IDBRequest { | ||
| property source nullable=#false | ||
| property result overrideType=T | ||
| property result type=T |
There was a problem hiding this comment.
It should be overrideType as T is not Web IDL type
Maybe overrideType needs a better name...
inputfiles/patches/indexeddb.kdl
Outdated
| @@ -0,0 +1,7 @@ | |||
| interface IDBRequest { | |||
| property source { | |||
| type "" nullable=#false | |||
There was a problem hiding this comment.
We can probably skip the type name in this case (and modify the code to accept that)
inputfiles/patches/indexeddb.kdl
Outdated
| type "" nullable=#false | ||
| } | ||
| property result overrideType=T | ||
| typeParameters T default=any |
|
I have fixed it |
|
LGTM, thanks! |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
2 participants
No description provided.