Skip to content

Migrate definitions for UnderlyingByteSource and UnderlyingDefaultSource #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Dec 16, 2025
Merged

Migrate definitions for UnderlyingByteSource and UnderlyingDefaultSource #2289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77cecd5
Migrate definitions for UnderlyingByteSource and UnderlyingDefaultSource
Bashamega Dec 15, 2025
b8710a9
change URL
saschanaz Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletions inputfiles/addedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,63 +644,6 @@
},
"dictionaries": {
"dictionary": {
"UnderlyingByteSource": {
"name": "UnderlyingByteSource",
"members": {
"member": {
"type": {
"name": "type",
"required": true,
"overrideType": "\"bytes\""
},
"autoAllocateChunkSize": {
"name": "autoAllocateChunkSize",
"type": "unsigned long long"
},
"start": {
"name": "start",
"overrideType": "(controller: ReadableByteStreamController) => any"
},
"pull": {
"name": "pull",
"overrideType": "(controller: ReadableByteStreamController) => void | PromiseLike<void>"
},
"cancel": {
"name": "cancel",
"type": "UnderlyingSourceCancelCallback"
}
}
}
},
"UnderlyingDefaultSource": {
"name": "UnderlyingDefaultSource",
"typeParameters": [
{
"name": "R",
"default": "any"
}
],
"members": {
"member": {
"type": {
"name": "type",
"type": "undefined"
},
"start": {
"name": "start",
"overrideType": "(controller: ReadableStreamDefaultController<R>) => any"
},
"pull": {
"name": "pull",
"overrideType": "(controller: ReadableStreamDefaultController<R>) => void | PromiseLike<void>"
},
"cancel": {
"name": "cancel",
"type": "UnderlyingSourceCancelCallback"
}
}
}
}
}
},
"typedefs": {
Expand Down
17 changes: 17 additions & 0 deletions inputfiles/patches/streams.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// https://streams.spec.whatwg.org/#dictdef-underlyingsource

dictionary UnderlyingDefaultSource {
typeParameters R default=any
member type type=undefined
member start overrideType="(controller: ReadableStreamDefaultController<R>) => any"
member pull overrideType="(controller: ReadableStreamDefaultController<R>) => void | PromiseLike<void>"
member cancel type=UnderlyingSourceCancelCallback
}

dictionary UnderlyingByteSource {
member type required=#true overrideType="\"bytes\""
member autoAllocateChunkSize type="unsigned long long"
member start overrideType="(controller: ReadableByteStreamController) => any"
member pull overrideType="(controller: ReadableByteStreamController) => void | PromiseLike<void>"
member cancel type=UnderlyingSourceCancelCallback
}