LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main #62068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
For Uncommitted Bug
There was a problem hiding this comment.
Pull Request Overview
This PR refines the diagnostic message for class names when targeting ES5 to clarify that the rule applies to ES5 and above, and propagates that change across multiple localized resource files.
- Updated the internal
ItemIdto use "ES5_and_above" instead of "ES5_with" for clarity. - Revised the English source string to read "Class name cannot be 'Object' when targeting ES5 and above with module {0}."
- Applied matching translation updates in Portuguese, Korean, Japanese, French, Traditional Chinese, and Simplified Chinese.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Portuguese translation for ES5 and above message |
| src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Korean translation for ES5 and above message |
| src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Japanese translation for ES5 and above message |
| src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and French translation for ES5 and above message |
| src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Traditional Chinese translation for ES5 and above |
| src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and Simplified Chinese translation for ES5 and above |
jakebailey
approved these changes
Jul 21, 2025
|
@microsoft-github-policy-service agree company="Microsoft" |
jakebailey
deleted the
lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main with localized lcls