Skip to content

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main #62068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csigs
Copy link
Member

@csigs csigs commented Jul 14, 2025

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main with localized lcls

@Copilot Copilot AI review requested due to automatic review settings July 14, 2025 19:24
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jul 14, 2025
@typescript-bot typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 14, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the diagnostic message for class names when targeting ES5 to clarify that the rule applies to ES5 and above, and propagates that change across multiple localized resource files.

  • Updated the internal ItemId to use "ES5_and_above" instead of "ES5_with" for clarity.
  • Revised the English source string to read "Class name cannot be 'Object' when targeting ES5 and above with module {0}."
  • Applied matching translation updates in Portuguese, Korean, Japanese, French, Traditional Chinese, and Simplified Chinese.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated ItemId and Portuguese translation for ES5 and above message
src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated ItemId and Korean translation for ES5 and above message
src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated ItemId and Japanese translation for ES5 and above message
src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated ItemId and French translation for ES5 and above message
src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated ItemId and Traditional Chinese translation for ES5 and above
src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated ItemId and Simplified Chinese translation for ES5 and above

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jul 21, 2025
@jakebailey jakebailey closed this Jul 21, 2025
@jakebailey jakebailey reopened this Jul 21, 2025
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jul 21, 2025
@github-project-automation github-project-automation bot moved this from Done to Not started in PR Backlog Jul 21, 2025
@csigs
Copy link
Member Author

csigs commented Jul 22, 2025

@microsoft-github-policy-service agree company="Microsoft"

@jakebailey jakebailey merged commit 22ef577 into main Jul 22, 2025
60 checks passed
@jakebailey jakebailey deleted the lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 branch July 22, 2025 20:23
@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Jul 22, 2025
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.9.1 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants