Skip to content

Add zizmor GitHub Actions security analysis workflow#15987

Draft
radical wants to merge 2 commits intomainfrom
ankj/add-zizmor-workflow
Draft

Add zizmor GitHub Actions security analysis workflow#15987
radical wants to merge 2 commits intomainfrom
ankj/add-zizmor-workflow

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Apr 8, 2026

Summary

Adds zizmor — a static analysis tool for GitHub Actions workflow security — to the CI pipeline.

What's included

.github/workflows/zizmor.yml

  • Non-blocking integration using SARIF upload to GitHub Code Scanning
  • Runs on PRs and pushes to main when workflow files change
  • Daily scheduled scan (06:30 UTC) to catch drift
  • Uses the official zizmorcore/zizmor-action (pinned to SHA)
  • Results appear in the Security → Code Scanning tab and as PR annotations

.github/zizmor.yml

  • Configuration file that suppresses dangerous-triggers findings on 4 workflows that intentionally use workflow_run/pull_request_target with explicit fork validation guards

Baseline scan

The initial scan found 236 findings (after suppression) across 33 of 39 workflows:

Severity Rule Count Notes
error template-injection 83 Mostly inputs.*, env.*, matrix.* in run: — not externally controllable
warning template-injection 40 Same pattern
warning artipacked 39 Missing persist-credentials: false — auto-fixable
warning excessive-permissions 28 Intentional write permissions for PR comments, checks, etc.
note template-injection 38 Low confidence
error excessive-permissions 8 Workflow-level write perms on backport/release workflows

These findings are informational and do not block CI. They'll be visible in the Security tab for gradual triage and improvement.

References

radical and others added 2 commits April 8, 2026 19:27
Adds a non-blocking zizmor workflow that:
- Runs on PRs and pushes to main when workflow files change
- Runs daily on a schedule to catch drift
- Uploads SARIF results to GitHub Code Scanning (Security tab)
- Uses the official zizmor-action with advanced-security enabled

This is a non-blocking integration - findings appear as annotations
and in the Security tab but do not fail the build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Suppresses dangerous-triggers findings on 4 workflows that
intentionally use workflow_run/pull_request_target with explicit
fork validation guards already in place.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15987

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15987"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🎬 CLI E2E Test Recordings — 56 recordings uploaded (commit 965d70a)

View recordings
Test Recording
AddPackageInteractiveWhileAppHostRunningDetached ▶️ View Recording
AddPackageWhileAppHostRunningDetached ▶️ View Recording
AgentCommands_AllHelpOutputs_AreCorrect ▶️ View Recording
AgentInitCommand_DefaultSelection_InstallsSkillOnly ▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig ▶️ View Recording
AllPublishMethodsBuildDockerImages ▶️ View Recording
AspireAddPackageVersionToDirectoryPackagesProps ▶️ View Recording
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps ▶️ View Recording
Banner_DisplayedOnFirstRun ▶️ View Recording
Banner_DisplayedWithExplicitFlag ▶️ View Recording
Banner_NotDisplayedWithNoLogoFlag ▶️ View Recording
CertificatesClean_RemovesCertificates ▶️ View Recording
CertificatesTrust_WithNoCert_CreatesAndTrustsCertificate ▶️ View Recording
CertificatesTrust_WithUntrustedCert_TrustsCertificate ▶️ View Recording
ConfigSetGet_CreatesNestedJsonFormat ▶️ View Recording
CreateAndRunAspireStarterProject ▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle ▶️ View Recording
CreateAndRunEmptyAppHostProject ▶️ View Recording
CreateAndRunJavaEmptyAppHostProject ▶️ View Recording
CreateAndRunJsReactProject ▶️ View Recording
CreateAndRunPythonReactProject ▶️ View Recording
CreateAndRunTypeScriptEmptyAppHostProject ▶️ View Recording
CreateAndRunTypeScriptStarterProject ▶️ View Recording
CreateJavaAppHostWithViteApp ▶️ View Recording
CreateStartAndStopAspireProject ▶️ View Recording
CreateTypeScriptAppHostWithViteApp ▶️ View Recording
DashboardRunWithOtelTracesReturnsNoTraces ▶️ View Recording
DescribeCommandResolvesReplicaNames ▶️ View Recording
DescribeCommandShowsRunningResources ▶️ View Recording
DetachFormatJsonProducesValidJson ▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig ▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted ▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted ▶️ View Recording
GlobalMigration_HandlesCommentsAndTrailingCommas ▶️ View Recording
GlobalMigration_HandlesMalformedLegacyJson ▶️ View Recording
GlobalMigration_PreservesAllValueTypes ▶️ View Recording
GlobalMigration_SkipsWhenNewConfigExists ▶️ View Recording
GlobalSettings_MigratedFromLegacyFormat ▶️ View Recording
InvalidAppHostPathWithComments_IsHealedOnRun ▶️ View Recording
LegacySettingsMigration_AdjustsRelativeAppHostPath ▶️ View Recording
LogsCommandShowsResourceLogs ▶️ View Recording
PsCommandListsRunningAppHost ▶️ View Recording
PsFormatJsonOutputsOnlyJsonToStdout ▶️ View Recording
PublishWithDockerComposeServiceCallbackSucceeds ▶️ View Recording
RestoreGeneratesSdkFiles ▶️ View Recording
RestoreSupportsConfigOnlyHelperPackageAndCrossPackageTypes ▶️ View Recording
RunFromParentDirectory_UsesExistingConfigNearAppHost ▶️ View Recording
RunWithMissingAwaitShowsHelpfulError ▶️ View Recording
SecretCrudOnDotNetAppHost ▶️ View Recording
SecretCrudOnTypeScriptAppHost ▶️ View Recording
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels ▶️ View Recording
StopAllAppHostsFromAppHostDirectory ▶️ View Recording
StopAllAppHostsFromUnrelatedDirectory ▶️ View Recording
StopNonInteractiveMultipleAppHostsShowsError ▶️ View Recording
StopNonInteractiveSingleAppHost ▶️ View Recording
StopWithNoRunningAppHostExitsSuccessfully ▶️ View Recording

📹 Recordings uploaded automatically from CI run #24164210779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant