Store polyglot artifacts under the workspace .aspire folder#15991
Draft
IEvangelist wants to merge 4 commits intomicrosoft:mainfrom
Draft
Store polyglot artifacts under the workspace .aspire folder#15991IEvangelist wants to merge 4 commits intomicrosoft:mainfrom
IEvangelist wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Move prebuilt AppHost staging and bundled restore output into the workspace-local .aspire directory, add default .gitignore coverage for generated polyglot projects, and cover the behavior with CLI tests. Co-authored-by: Copilot <[email protected]>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15991Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15991" |
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Use OS-neutral path composition in TemplateGitIgnoreTests so the starter template .gitignore assertions work on Ubuntu runners as well as Windows. Co-authored-by: Copilot <[email protected]>
Root the generated .aspire ignore entry at /.aspire/, merge it into an existing root .gitignore instead of overwriting it, and fail scaffolding when other returned files already exist. Co-authored-by: Copilot <[email protected]>
Keep the project-root .gitignore behavior and safe merge logic, but revert the generated ignore entry itself back to .aspire/ to match the intended template output. Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aspire.config.json(or legacy.aspire/settings.json) and store workspace-scoped CLI artifacts under<workspace>/.aspire/..., including bundled restore output and prebuilt AppHost staging.gitignoreentry for.aspire/to generated TypeScript, Python, and Java projects so the new workspace-local artifact folder stays untracked by default.gitignorewhen scaffolding a polyglot AppHost by appending missing ignore entries instead of overwriting the file, and fail scaffolding if any other returned project files already existFixes #15967.
Testing
dotnet test tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj -- --filter-class Aspire.Cli.Tests.Templating.TemplateGitIgnoreTests --filter-class Aspire.Cli.Tests.Scaffolding.ScaffoldingServiceTestsdotnet build tests/Aspire.Cli.EndToEnd.Tests/Aspire.Cli.EndToEnd.Tests.csprojConfigurationHelperTests,BundleNuGetServiceTests, andPrebuiltAppHostServerTestsaspire new ts-starterandaspire new tsgenerated a project-root.gitignorecontaining the.aspire/entry