Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16144Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16144" |
There was a problem hiding this comment.
Pull request overview
Updates the aspire describe table header from “Endpoints” to “URLs” to align CLI terminology with the dashboard.
Changes:
- Renamed the localized resource key/value from
HeaderEndpoints→HeaderURLs(RESX + XLFs). - Updated the generated resource designer accessor accordingly.
- Switched the
DescribeCommandtable column header to use the new resource string.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.zh-Hant.xlf | Replaces HeaderEndpoints with HeaderURLs for zh-Hant localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.zh-Hans.xlf | Replaces HeaderEndpoints with HeaderURLs for zh-Hans localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.tr.xlf | Replaces HeaderEndpoints with HeaderURLs for Turkish localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.ru.xlf | Replaces HeaderEndpoints with HeaderURLs for Russian localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.pt-BR.xlf | Replaces HeaderEndpoints with HeaderURLs for pt-BR localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.pl.xlf | Replaces HeaderEndpoints with HeaderURLs for Polish localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.ko.xlf | Replaces HeaderEndpoints with HeaderURLs for Korean localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.ja.xlf | Replaces HeaderEndpoints with HeaderURLs for Japanese localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.it.xlf | Replaces HeaderEndpoints with HeaderURLs for Italian localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.fr.xlf | Replaces HeaderEndpoints with HeaderURLs for French localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.es.xlf | Replaces HeaderEndpoints with HeaderURLs for Spanish localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.de.xlf | Replaces HeaderEndpoints with HeaderURLs for German localization. |
| src/Aspire.Cli/Resources/xlf/DescribeCommandStrings.cs.xlf | Replaces HeaderEndpoints with HeaderURLs for Czech localization. |
| src/Aspire.Cli/Resources/DescribeCommandStrings.resx | Renames the base resource entry to HeaderURLs=URLs. |
| src/Aspire.Cli/Resources/DescribeCommandStrings.Designer.cs | Updates the strongly-typed resource property name and lookup key to HeaderURLs. |
| src/Aspire.Cli/Commands/DescribeCommand.cs | Uses DescribeCommandStrings.HeaderURLs for the table header. |
Files not reviewed (1)
- src/Aspire.Cli/Resources/DescribeCommandStrings.Designer.cs: Language not supported
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">终结点</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">URL'ler</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">URL-адреса</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">URL</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">URL</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">網址</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">URLs</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">Adresy URL</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">Direcciones URL</target> |
| </trans-unit> | ||
| <trans-unit id="HeaderURLs"> | ||
| <source>URLs</source> | ||
| <target state="new">URLs</target> |
There was a problem hiding this comment.
The new HeaderURLs string is left untranslated (target is still "URLs" with state="new"), which will regress the localized output compared to the previously translated HeaderEndpoints entry. Please provide an appropriate translation for this locale (and mark the target state accordingly), or ensure this string is picked up by the localization workflow before shipping.
| <target state="new">URLs</target> | |
| <target state="translated">Adresy URL</target> |
|
🎬 CLI E2E Test Recordings — 71 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24386694016 |
Description
aspire describehas a table with an Endpoints column. PR renames it to URLs to be consistent with the dashboard.Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: