Support bot sdk dot net for targeted meeting notification - #6570
Conversation
| } | ||
|
|
||
| /// <summary> | ||
| /// Sends a notification to meeting participants. This functionality is available only in teams meeting scoped conversations. |
There was a problem hiding this comment.
Does this mean that this feature won't work in a group chat meeting?
Does it make sense to fix the missed lines with unit tests? Hi Kavin (@singhk97) , according to previous code coverage in the same class, we don't write unit test for trace report and throw exception. |
a5268f5 to
468c6df
Compare
|
/azp run BotBuilder-DotNet-CI-PR-(MacLinux)-yaml |
|
Azure Pipelines successfully started running 1 pipeline(s). |
johnataylor
left a comment
There was a problem hiding this comment.
Just the comment style. We don't want C style comments.
I have some minor comments on the code, but what you have is consistent with the old generated code so I think we can leave it.
|
|
||
| if ((int)statusCode == 207) | ||
| { | ||
| /* 207: if the notifications are sent only to parital number of recipients because |
There was a problem hiding this comment.
don't use C style comments /* */ just use //
| } | ||
| else if ((int)statusCode != 202) | ||
| { | ||
| /* |
There was a problem hiding this comment.
don't use C style comments /* */ just use //
| [InlineData("403")] | ||
| public async Task TestSendMeetingNotificationAsync(string statusCode) | ||
| { | ||
| /* |
There was a problem hiding this comment.
don't use C style comments /* */ just use //
|
yingduyingdu I've made the Mac build pipeline optional for this PR, so it's not blocking, we'll fix the pipeline week after next. |
468c6df to
d07ec16
Compare
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
Description
This feature aims to extend the dot Net Bot SDK so that developers can send targeted meeting notifications in Microsoft Teams meetings.
Add
TeamsInfo.SendMeetingNotificationAsyncCloses #6571
Changes
Microsoft.Bot.Builder/TeamsSendMeetingNotificationAsyncmethod inTeamsInfo.csMicrosoft.Bot.Connector/TeamsMicrosft.Bot.Schema/TeamsTesting
Test
SendMeetingNotificationAsyncfor different status codes inTeamsInfoTests.cs.