Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Add WithAuthority to MSAL client application builder - #6671

Merged
tracyboehrer (tracyboehrer) merged 1 commit into
microsoft:mainfrom
southworks:southworks/fix/msal-authority
Jul 13, 2023
Merged

Add WithAuthority to MSAL client application builder#6671
tracyboehrer (tracyboehrer) merged 1 commit into
microsoft:mainfrom
southworks:southworks/fix/msal-authority

Conversation

@sw-joelmut

Copy link
Copy Markdown
Collaborator

#minor

Description

This PR fixes an issue in MSAL where the Authority for Government, Office 365 GCC High and DoD was not set in the MSAL credentials' application level.

Specific Changes

  • Added WithAuthority to Certificate, Microsoft and Msal app credentials when creating the client application builder.

Testing

The following images show the tests passing successfully and the Echo bot working in Public Cloud.
image
image

@sw-joelmut Joel Mut (sw-joelmut) added the Automation: No parity PR does not need to be applied to other languages. label Jul 12, 2023
@sw-joelmut
Joel Mut (sw-joelmut) requested a review from a team as a code owner July 12, 2023 20:12
@tracyboehrer
tracyboehrer (tracyboehrer) merged commit 332d26c into microsoft:main Jul 13, 2023
tracyboehrer (tracyboehrer) added a commit that referenced this pull request Jul 13, 2023
* Upgrade Antlr4.Runtime to v.4.11.1 (#6670)

* Add WithAuthority to MSAL application level (#6671)

* Use LRUCache in ExpressionParser for efficient memory usage (#6667)

* Microsoft.Rest.ClientRuntime bump (#6662)

Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>

* Updated NuGet.Packaging (#6652)

Co-authored-by: PVAShiproom <pvashiproom@microsoft.com>

---------

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Co-authored-by: Ram Fattah <38049078+ramfattah@users.noreply.github.com>
Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>
Co-authored-by: PVAShiproom <pvashiproom@microsoft.com>
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants