Skip to content

Fix optional typing issue #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix optional typing issue #2211

wants to merge 1 commit into from

Conversation

VictorErmakov
Copy link

@VictorErmakov VictorErmakov commented Mar 3, 2025 •
edited
Loading

Description

Typing for optional str, int, bool with default value None is incorrect.

Specific Changes

  • Change str = None to Union[str, None] = None
  • Change int = None to Union[int, None] = None
  • Change bool = None to Union[bool, None] = None

@VictorErmakov VictorErmakov requested a review from a team as a code owner March 3, 2025 13:03
@VictorErmakov
Copy link
Author

@microsoft-github-policy-service agree

@tracyboehrer tracyboehrer requested a review from axelsrz May 28, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axelsrz axelsrz Awaiting requested review from axelsrz

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@VictorErmakov