-
Notifications
You must be signed in to change notification settings - Fork 52
Add symmetric encryption & tests #112
base: master
Are you sure you want to change the base?
Conversation
Yes, this one replaces 80,81 -- I just closed those two. |
Perfect! Thanks! We'll look into it soon! We're currently looking into a larger effort to expose a few, much used, .NET libraries. Encryption is part of that effort and there is hence quite some overlap. We'll keep you posted! |
Can you make sure that the ClosedXML is a part of that .NET libraries added... |
Sorry to bother -- can you provide an update on this request? Thanks. |
What do you want me to update? |
We’re still on track to include some form of implementation of this in the next major! It will be released as part of our Spring Release. If we have questions, we’ll get back to you. |
BaseApp/COD50012.TXT
Outdated
END; | ||
|
||
[External] | ||
PROCEDURE ComputeHashFromText@1000000000(VAR Text@1000000001 : Text;VAR DotNet_Array@1000 : Codeunit 3000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intention is to wrap ComputeHash(Byte[]), why don't you pass an array of bytes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are situations where the data in the calling code will reside in a stream (uploaded file, etc) so this interface makes the calling code simpler (no need to allocate and fill an array). however, your point is valid, there are also situations where the data may reside in an array -- so I have added the "ComputeHash(DotNet_Array, ...)" interface per your comment -- please confirm this is what you expected
Addded wrappers for CryptoStream properties Updated interfaces to use enums Updated tests
Removed unused variables. Corrected export syntax (accidentally used ExportToNewSyntax in last commit)
Just downloaded / installed the BC Spring update -- was hoping to see this pull or some other symmetric encryption implementation in it but no luck. Are there plans for symmetric encryption support in BC? |
Added wrappers for DotNet classes:
System.Security.Cryptography.SymmetricAlgorithm
System.Security.Cryptography.HashAlgorithm
System.Security.Cryptography.ICryptoTransform
System.Security.Cryptography.CryptoStream
Modified existing wrappers:
Codeunit 3000 DotNet_Array
Codeunit 3025 DotNet_StreamWriter
Codeunit 3027 DotNet_StreamReader
Added new codeunit:
Symmetric Encryption Mgt
Added/modified tests for all changes.