-
Notifications
You must be signed in to change notification settings - Fork 106
enable nullable by default #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cataggar
wants to merge
5
commits into
microsoft:main
Choose a base branch
from
cataggar:nullable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+416
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
commented
Oct 14, 2025
src/Microsoft.ComponentDetection.Common/DockerReference/DigestUtility.cs
Outdated
Show resolved
Hide resolved
cataggar
commented
Oct 14, 2025
src/Microsoft.ComponentDetection.Common/Utilities/StringUtilities.cs
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1471 +/- ##
=======================================
- Coverage 89.8% 89.8% -0.1%
=======================================
Files 413 413
Lines 33117 33117
Branches 2047 2047
=======================================
- Hits 29767 29766 -1
Misses 2935 2935
- Partials 415 416 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The CI build is currently failing due to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enabled nullable by default and then adds
#nullable disable
anywhere it is needed in the current code. This will help ensure new code uses nullable and allows existing code to move to it incrementally. This follows the official guidance for moving to nullable.Incremental step for
Following step 2 in https://learn.microsoft.com/en-us/dotnet/csharp/nullable-migration-strategies :
3435980 by Copilot in
e9ff160 by Copilot locally.