Dev: provide ability to set timeout options #109
Conversation
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Files not reviewed (2)
- src/views/ModelSelectionDialog.tsx: Evaluated as low risk
- src/app/dfSlice.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)
py-src/data_formulator/app.py:499
- Update comment to reflect the new logic of trying up to max_repair_attempts times.
# only try once
src/app/App.tsx
Outdated
| type="number" | ||
| variant="outlined" | ||
| value={formulateTimeoutSeconds} | ||
| onChange={(e) => setFormulateTimeoutSeconds(parseInt(e.target.value))} |
There was a problem hiding this comment.
The input value should be validated to ensure it is a valid number and within an acceptable range.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
src/app/App.tsx
Outdated
| type="number" | ||
| variant="outlined" | ||
| value={maxRepairAttempts} | ||
| onChange={(e) => setMaxRepairAttempts(parseInt(e.target.value))} |
There was a problem hiding this comment.
The input value should be validated to ensure it is a valid number and within an acceptable range.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
py-src/data_formulator/app.py
Outdated
| print("max_repair_attempts") | ||
| print(max_repair_attempts) | ||
| print("previous dialog") | ||
| print(dialog) | ||
|
|
There was a problem hiding this comment.
Remove debugging print statement.
| print("max_repair_attempts") | |
| print(max_repair_attempts) | |
| print("previous dialog") | |
| print(dialog) | |
| app.logger.info(f"max_repair_attempts: {max_repair_attempts}") | |
| app.logger.info(f"previous dialog: {dialog}") |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
py-src/data_formulator/app.py
Outdated
| print("max_repair_attempts") | ||
| print(max_repair_attempts) | ||
| print("previous dialog") | ||
| print(dialog) | ||
|
|
There was a problem hiding this comment.
Remove debugging print statement.
| print("max_repair_attempts") | |
| print(max_repair_attempts) | |
| print("previous dialog") | |
| print(dialog) | |
| app.logger.info(f"max_repair_attempts: {max_repair_attempts}") | |
| app.logger.info(f"previous dialog: {dialog}") |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Dev: provide ability for users to set timeout options and max-retry attempts. This would be helpful for slower models.