Enable FailFastOnErrors for debug builds (#3244)

microsoft · Jun 19, 2024 · 26e01a7 · 26e01a7
1 parent b9c628e
commit 26e01a7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/App.xaml.cs b/src/App.xaml.cs
@@ -79,6 +79,9 @@ private static string RemoveComments(string text)
     public App()
     {
         InitializeComponent();
+#if DEBUG
+        DebugSettings.FailFastOnErrors = true;
+#endif
         _dispatcherQueue = DispatcherQueue.GetForCurrentThread();
 
         Host = Microsoft.Extensions.Hosting.Host.

diff --git a/src/DevHome.csproj b/src/DevHome.csproj
@@ -156,6 +156,10 @@
     <DefineConstants Condition="'$(BuildRing)'=='Stable'">$(DefineConstants);STABLE_BUILD</DefineConstants>
   </PropertyGroup>
 
+  <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
+    <DefineConstants>$(DefineConstants);DEBUG</DefineConstants>
+  </PropertyGroup>
+
   <!-- Third party notice file -->
   <ItemGroup>
     <Content Include="$(SolutionDir)NOTICE.txt">

diff --git a/src/MainWindow.xaml.cs b/src/MainWindow.xaml.cs
@@ -29,5 +29,9 @@ private void MainWindow_Closed(object sender, WindowEventArgs args)
         Application.Current.GetService<IExtensionService>().SignalStopExtensionsAsync();
         TelemetryFactory.Get<ITelemetry>().Log("DevHome_MainWindow_Closed_Event", LogLevel.Critical, new DevHomeClosedEvent(_mainWindowCreated));
         Log.Information("Terminating via MainWindow_Closed.");
+
+        // WinUI bug is causing a crash on shutdown when FailFastOnErrors is set to true (#51773592).
+        // Workaround by turning it off before shutdown.
+        App.Current.DebugSettings.FailFastOnErrors = false;
     }
 }