Skip to content

Commit

Permalink
Adding global info bar (#4028)
Browse files Browse the repository at this point in the history
* Adding shell info bar

* Disabling warning

* Disabling warning

* Disabling warnings

---------

Co-authored-by: Felipe da Conceicao Guimaraes <[email protected]>
  • Loading branch information
guimafelipe and Felipe da Conceicao Guimaraes authored Jan 27, 2025
1 parent 1bbf272 commit d6d0147
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ private async Task InstallOrUpdateAppInstallerIfNeeded(IProgress<DevSetupEngineT
}
}

#pragma warning disable CA1859
public async Task<DevSetupEngineTypes.IApplyConfigurationResult> ApplyConfigurationAsync(string content, IProgress<DevSetupEngineTypes.IConfigurationSetChangeData> progress)
{
DevSetupEngineTypes.IOpenConfigurationSetResult? openConfigurationSetResult = default;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ public async Task ValidateConfigurationAsync(IDSCFile file)
/// </summary>
/// <param name="result">Result of applying the configuration set</param>
/// <param name="activityId">Activity ID</param>
#pragma warning disable CA1859
private void ReportApplyConfigurationResult(IDSCApplicationResult result, Guid activityId)
{
foreach (var unitResult in result.UnitResults)
Expand Down
3 changes: 3 additions & 0 deletions src/Strings/en-us/Resources.resw
Original file line number Diff line number Diff line change
Expand Up @@ -292,4 +292,7 @@
<data name="GPODisabledDevHomeDescription.Text" xml:space="preserve">
<value>Check with your IT or System Administrator for support.</value>
</data>
<data name="ShellInfoBar.Message" xml:space="preserve">
<value>Dev Home will be going away in May 2025 and a subset of its features will be moved to new places. Stay tuned for more information in the following months.</value>
</data>
</root>
2 changes: 2 additions & 0 deletions src/Views/ShellPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@
</Grid>
</NavigationView>

<InfoBar x:Uid="ShellInfoBar" IsOpen="True" Severity="Error" Margin="20,40,20,10"></InfoBar>

<StackPanel
Grid.Row="1"
HorizontalAlignment="Center"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ private bool ShouldShowDashboardBanner()
}

#if DEBUG
#pragma warning disable CA1853
public void ResetDashboardBanner()
{
ShowDashboardBanner = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1058,6 +1058,7 @@ private void AddResetButton(object sender, RoutedEventArgs e)
parent.Children.Insert(index + 1, resetButton);
}

#pragma warning disable CA1853
private void ResetButton_Click(object sender, RoutedEventArgs e)
{
var roamingProperties = Windows.Storage.ApplicationData.Current.RoamingSettings.Values;
Expand Down

0 comments on commit d6d0147

Please sign in to comment.