#4235 - added pin/unpin netsh commands for maps and programs #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zodiacon
requested review from
Alan-Jowett,
dthaler,
dv-msft,
LakshK98,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag,
shankarseal and
vpidatala94
as code owners
dthaler
reviewed
Feb 28, 2025
dthaler
reviewed
Mar 4, 2025
dthaler
reviewed
Mar 4, 2025
dthaler
reviewed
Mar 5, 2025
There was a problem hiding this comment.
https://github.com/microsoft/ebpf-for-windows/blob/main/CONTRIBUTING.md says:
Tests need to be provided for every bug/feature that is completed.
Please update tests\end_to_end\netsh_test.cpp with tests for these commands.
dthaler
previously approved these changes
Mar 5, 2025
Co-authored-by: Dave Thaler <[email protected]>
Co-authored-by: Dave Thaler <[email protected]>
Co-authored-by: Dave Thaler <[email protected]>
dthaler
reviewed
Mar 7, 2025
dthaler
approved these changes
Mar 7, 2025
Alan-Jowett
approved these changes
Mar 10, 2025
|
I don't have the power to merge... |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new commands to netsh:
pin map <id> [pinpath]
unpin map <id> [pinpath]
pin program <id> [pinpath]
unpin program <id> [pinpath]
#4235