support partial output buffer for get_info API. #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
requested review from
Alan-Jowett,
dthaler,
dv-msft,
LakshK98,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
vpidatala94
as code owners
dthaler
approved these changes
Mar 18, 2025
mikeagun
approved these changes
Mar 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
This PR fixes #4160 by allowing smaller output buffer than the size of the struct for
bpf_obj_get_info_by_fdAPI. The changes were made for program, map and link objects. This PR found two incidental issues:count_of_mapsfor eBPF program object was set to the count of map references in individual instructions, instead of total number of unique maps referred to by the program.query_map_definitioninvokedbpf_obj_get_info_by_fdbut did not check if the returned object type was indeed that of a map.Testing
Do any existing tests cover this change? Are new tests needed?
Test cases were added in libbpf unit tests to invoke ``bpf_obj_get_info_by_fd` with smaller output buffers.
Documentation
Is there any documentation impact for this change?
N/A.
Installation
Is there any installer impact for this change?
N/A.