Skip to content

Conversation

@mitokic
Copy link
Collaborator

@mitokic mitokic commented Dec 13, 2025

This pull request updates the finnts package version and improves the logic for handling multiple recipes in the agent forecast loading process. The most significant change is the enhancement to support averaging when multiple recipes are used, in addition to the existing support for multiple models.

Version bump and documentation:

  • Updated the package version to 0.6.0.9015 in both the DESCRIPTION and NEWS.md files to reflect the new development version. [1] [2]

Forecast loading improvements:

  • Added detection of multiple recipes by checking for "---" in the recipes_to_run field and updated the logic to include average model files when either multiple models or multiple recipes are used with averaging enabled in load_agent_forecast. [1] [2]…ut two recipes, and load forecast is not picking up the avg file

…ut two recipes, and load forecast is not picking up the avg file
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the forecast loading logic where average model files were not being loaded when a combination used multiple recipes with a single model and averaging was enabled. The version was bumped to 0.6.0.9015 to reflect this development change.

Key Changes:

  • Added detection for multiple recipes by checking for the "---" separator in the recipes_to_run field
  • Updated the condition to load average model files when either multiple models OR multiple recipes are used with averaging enabled

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
R/agent_iterate_forecast.R Added multiple_recipes detection and updated the condition to include it in the check for loading average model files
NEWS.md Updated version number to 0.6.0.9015
DESCRIPTION Updated package version to 0.6.0.9015

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mitokic mitokic marked this pull request as ready for review December 15, 2025 15:49
@mitokic mitokic requested a review from smdp2000ofc December 15, 2025 15:50
@mitokic mitokic merged commit 4f9e030 into main Dec 15, 2025
9 of 16 checks passed
@mitokic mitokic deleted the mitokic/12132025/agent-load-fcst-fix branch December 15, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants