-
Notifications
You must be signed in to change notification settings - Fork 44
feat: migrate releases to Nx version plans and new decoupled release flow #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Hotell
wants to merge
9
commits into
microsoft:main
Choose a base branch
from
Hotell:migrate-to-version-plans
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3eca6ce
Change files
Hotell c0870f9
api change
Hotell e919b70
plan file
Hotell 6a3bf5e
ci: use nx release for publishing
Hotell f56dad5
chore: use dependsOn for nx-release-publish instead manually running …
Hotell 58e3656
ci: separate release pipeline into 2 jobs
Hotell 55820f5
chore: undo changes
Hotell 311bf86
chore: migrate to nx 21
Hotell f31ce04
chore: run nx 21 migrations
Hotell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
react-shadow: patch | ||
--- | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove |
||
|
||
new api added yay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,17 @@ | |
pr: none | ||
trigger: none | ||
|
||
parameters: | ||
- name: dry_run | ||
displayName: Dry run mode | ||
type: boolean | ||
default: true | ||
# Projects to include within release. (comma/space delimited project names and/or patterns). See `--project` flag for more details https://nx.dev/nx-api/nx/documents/release#publish | ||
- name: projects | ||
displayName: Projects to release (defaults to all) | ||
type: string | ||
default: '' | ||
|
||
variables: | ||
- name: NX_PARALLEL | ||
value: 8 | ||
|
@@ -33,6 +44,7 @@ extends: | |
- stage: main | ||
jobs: | ||
- job: Release | ||
displayName: 'Release New Version' | ||
pool: | ||
name: '1ES-Host-Ubuntu' | ||
image: '1ES-PT-Ubuntu-20.04' | ||
|
@@ -54,24 +66,68 @@ extends: | |
echo "##vso[task.setvariable variable=shellopts]braceexpand:hashall:interactive-comments:errexit:errtrace" | ||
displayName: Force exit on error (bash) | ||
|
||
- task: NodeTool@0 | ||
- task: UseNode@1 | ||
inputs: | ||
versionSpec: '20.x' | ||
checkLatest: true | ||
checkLatest: false | ||
displayName: 'Install Node.js' | ||
|
||
- script: yarn install --frozen-lockfile | ||
displayName: Install dependencies | ||
|
||
- script: | | ||
yarn nx run-many -t build,test,lint,type-check -p ${{ parameters.projects }} --nxBail | ||
condition: eq(parameters.dry_run, false) | ||
displayName: Verify publishable Assets | ||
|
||
- script: | | ||
git config user.name "Fluent UI Build" | ||
git config user.email "[email protected]" | ||
git remote set-url origin https://$(githubUser):$(githubPAT)@github.com/microsoft/fluentui-contrib.git | ||
condition: eq(parameters.dry_run, false) | ||
displayName: Authenticate git for pushes | ||
|
||
- script: | | ||
yarn beachball publish -b origin/main --access public -y -n $(npmToken) | ||
git reset --hard origin/main | ||
yarn nx release --skip-publish -p ${{ parameters.projects }} --dry-run ${{ parameters.dry_run }} --verbose | ||
displayName: Bump versions and generate Changelogs | ||
|
||
# NOTE: this step needs PAT - needs different release flow to avoid PATs completely | ||
- script: | ||
| # TODO: remove this step once https://github.com/nrwl/nx/issues/30551 is resolved | ||
git push origin && git push origin --tags | ||
condition: eq(parameters.dry_run, false) | ||
displayName: Propagate Release to GitHub | ||
env: | ||
GITHUB_PAT: $(githubPAT) | ||
displayName: Publish to NPM & bump versions | ||
|
||
- job: PublishToNPM | ||
displayName: 'Publish to NPM' | ||
dependsOn: Release | ||
condition: succeeded('Release') | ||
pool: | ||
name: '1ES-Host-Ubuntu' | ||
image: '1ES-PT-Ubuntu-20.04' | ||
os: linux | ||
workspace: | ||
clean: all | ||
templateContext: | ||
outputs: | ||
- output: pipelineArtifact | ||
targetPath: $(System.DefaultWorkingDirectory)/packages | ||
artifactName: output | ||
steps: | ||
- task: UseNode@1 | ||
inputs: | ||
versionSpec: '20.x' | ||
checkLatest: false | ||
displayName: 'Install Node.js' | ||
|
||
- script: yarn install --frozen-lockfile | ||
displayName: Install dependencies | ||
|
||
# NOTE: `nx release publish` executes `nx-release-publish` target and all its dependents | ||
- script: | | ||
yarn nx release publish -p ${{ parameters.projects }} --dry-run ${{ parameters.dry_run }} | ||
displayName: Publish to NPM | ||
env: | ||
NODE_AUTH_TOKEN: $(npmToken) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
export { createRoot, root } from './root'; | ||
|
||
export const apiV2 = 'noop'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nx is used for releases, so we need it to be installed -> removing artificial ci-change workflow