Fix disabled, selected Tab in TabList from impeding keyboarding navigation when trying to tab in #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a selected tab manages to be disabled, the user cannot change keyboard focus to the tablist or any element beyond that. This commit fixes the issue.
rurikoaraki
reviewed
Nov 21, 2023
ksiler
reviewed
Nov 22, 2023
rurikoaraki
reviewed
Nov 22, 2023
rurikoaraki
reviewed
Nov 22, 2023
rurikoaraki
reviewed
Nov 22, 2023
rurikoaraki
reviewed
Nov 28, 2023
rurikoaraki
reviewed
Nov 28, 2023
rurikoaraki
reviewed
Nov 28, 2023
rurikoaraki
approved these changes
Nov 29, 2023
ksiler
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Currently, whenever a selected tab becomes disabled, this prevents keyboard users from switching focus to the TabList and any other elements after.
This PR fixes this by setting the defaultTabbableElement of the TabList's focus zone to the next available Tab if a selected tab becomes disabled. In the edge case where every tab is disabled, the TabList's state will become disabled and focus should skip the TabList entirely.
Verification
New Behavior:
https://github.com/microsoft/fluentui-react-native/assets/15683103/7395c4d1-1085-4b19-a5e5-1716f7a27122
Pull request checklist
This PR has considered (when applicable):