feat(react-charting): Support for Funnel Chart #34688
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers/srmukher/funnel_chart
…ers/srmukher/funnel_chart
📊 Bundle size report✅ No changes found |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Drawer.overlay drawer full - High Contrast.chromium.png | 6688 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 712 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 725 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1321 | Changed |
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 659 | Changed |
vr-tests/react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
vr-tests/react-charting-GaugeChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-GaugeChart.Basic.default.chromium.png | 2 | Changed |
vr-tests/react-charting-LineChart 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-LineChart.Events.default.chromium.png | 1 | Changed |
| vr-tests/react-charting-LineChart.Multiple.default.chromium.png | 192 | Changed |
| vr-tests/react-charting-LineChart.Multiple - RTL.default.chromium.png | 200 | Changed |
| vr-tests/react-charting-LineChart.Multiple - Dark Mode.default.chromium.png | 181 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
|
what is the size increase for DeclarativeChart with this addition. |
AtishayMsft
reviewed
Jun 21, 2025
| orientation: 'horizontal', | ||
| }; | ||
|
|
||
| function renderSegmentText({ |
There was a problem hiding this comment.
The segment text color has to ensure color contrast. See
AtishayMsft
reviewed
Jun 21, 2025
| culture, | ||
| onMouseOver: event => _handleStackedHover(cur.stage as string, v, event), | ||
| onMouseMove: event => _handleStackedHover(cur.stage as string, v, event), | ||
| onMouseOut: () => _handleMouseOut(), |
There was a problem hiding this comment.
put all these props in an object called eventHandlerProps and reuse everywhere
AtishayMsft
reviewed
Jun 21, 2025
| alignmentBaseline="middle" | ||
| onMouseOver={onMouseOver} | ||
| onMouseMove={onMouseMove} | ||
| onMouseOut={onMouseOut} |
AtishayMsft
reviewed
Jun 21, 2025
| if (orientation === 'horizontal') { | ||
| for (let i = 0; i < stages.length; i++) { | ||
| const cur = stages[i]; | ||
| for (let k = 0; k < (cur.subValues ?? []).length; k++) { |
|
1 issue. The text in the bottom segment is not in the center vertically. 
|
|
Another issue: Multi legend selection is not working |
|
Highlighting on chart on stacked case is making all segments greyed out.
|
|
Could you add all these cases in contrib repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design doc: https://microsoft.sharepoint.com/:w:/t/EDIndiaAmplifyTeam/EXXIjOWQXCFAu9pi2eebrm8BvYVYgBEaPmklSkRy0-bv0Q?e=LdxFHY
Work item https://uifabric.visualstudio.com/iss/_workitems/edit/12783/