fix(Carousel): fixed re-focus to opposite navigation button in 2 card edge case #34689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathis-m
commented
Jun 20, 2025
packages/react-components/react-carousel/library/src/components/Carousel/Carousel.cy.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When having 2 slides in the carousel either the prev or next button is disabled.
The current behavior does a re-focus from one to the other button if clicked/invoked if certain conditions are met(not relevant for this fix).
The focus call happend syncronously with the invoke. This led to the opposite button not receiving focused as it is still disabled.
New Behavior
Changed the focus call to be executed after layout is resolved by using requestAnimationFrame.
Related Issue(s)