-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Extended Tokens: Text area #34692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
etudie
wants to merge
4
commits into
microsoft:extended-tokens
Choose a base branch
from
etudie:textArea
base: extended-tokens
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extended Tokens: Text area #34692
+250
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request demo site: URL |
.../react-components/react-textarea/library/src/components/Textarea/useTextareaStyles.styles.ts
Outdated
Show resolved
Hide resolved
.../react-components/react-textarea/library/src/components/Textarea/useTextareaStyles.styles.ts
Outdated
Show resolved
Hide resolved
Mitch-At-Work
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the
@fluentui/react-textarea
package and its related styles, focusing on transitioning from legacy tokens to semantic tokens for improved maintainability and consistency. Additionally, changes were made to semantic token definitions to support this transition. The updates enhance the styling of theTextarea
component and ensure alignment with the new semantic token system.Updates to
Textarea
Component Styles:Replaced legacy tokens (
tokens
) with semantic tokens (semanticTokens
) for styling properties such asborderRadius
,backgroundColor
, andborder
inuseTextareaStyles.styles.ts
. This ensures consistent theming across components. [1] [2] [3] [4]Updated placeholder text and typography styles (e.g.,
fontSize
,lineHeight
) to use semantic tokens for better alignment with design specifications. [1] [2]Semantic Token Enhancements:
Added new semantic tokens, such as
_ctrlFocusOuterStrokeInteractive
and_ctrlInputBackgroundRestDarker
, to support the updatedTextarea
styles. These tokens provide fallback values for better compatibility. [1] [2]Enhanced existing semantic tokens by adding fallback values sourced from legacy tokens, ensuring smooth transition and backward compatibility. For example,
ctrlInputBackgroundDisabled
now includes a fallback tocolorNeutralBackgroundDisabled
. [1] [2]Token Definitions in
semantic-tokens
:Updated
tokens.ts
to include fallback values for semantic tokens, such asctrlInputBackgroundRest
andctrlInputStrokeRest
. These changes align token definitions with the new semantic token system.Imported legacy token values into
tokens.ts
to provide additional fallbacks for semantic tokens, ensuring consistent rendering across different themes.