fix(react-charting): Improve legend selection for Scatter charts #34701
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests/react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
AtishayMsft
reviewed
Jun 23, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "patch", | |||
| "comment": "fix(react-charting): Improve legend selection for Scatter charts", | |||
AtishayMsft
reviewed
Jun 23, 2025
| setSelectedLegends(props.legendProps?.selectedLegends || []); | ||
| } | ||
| } else { | ||
| setSelectedLegends(props.legendProps?.selectedLegends || []); |
There was a problem hiding this comment.
I don't see any difference in if and else condition statements
AtishayMsft
reviewed
Jun 23, 2025
| return selectedLegends.length === 0; | ||
| }, [selectedLegends]); | ||
| return selectedLegends.length === 0 && activeLegend === ''; | ||
| }, [selectedLegends, activeLegend]); |
There was a problem hiding this comment.
use _getHighlightedLegend.length === 0?
AtishayMsft
reviewed
Jun 23, 2025
| @@ -358,8 +359,8 @@ export const ScatterChartBase: React.FunctionComponent<IScatterChartProps> = Rea | |||
| * This function checks if none of the legends is selected or hovered.*/ | |||
|
|
|||
| const _noLegendHighlighted = React.useCallback((): boolean => { | |||
There was a problem hiding this comment.
does this fix issue of legend hover not working also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item: https://uifabric.visualstudio.com/iss/_workitems/edit/13025
fix(react-charting): Improve legend selection for Scatter charts