Skip to content

Ensure that all in-memory records are checkpointed when not using --storage-tier #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ted Hart (TedHartMS) merged 2 commits into from
Mar 25, 2024
Merged

Ensure that all in-memory records are checkpointed when not using --storage-tier #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77595b2
Ensure that all in-memory records are checkpointed when not using --s…
TedHartMS Mar 24, 2024
42eeb2b
Merge branch 'main' into tedhar/nulldev-chkpt-fix
badrishc Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libs/storage/Tsavorite/cs/src/core/Index/Synchronization/HybridLogCheckpointTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,9 @@ public override void GlobalBeforeEnteringState<Key, Value>(SystemState next, Tsa
store._hybridLogCheckpoint.snapshotFileDevice.Initialize(store.hlog.GetSegmentSize());
store._hybridLogCheckpoint.snapshotFileObjectLogDevice.Initialize(-1);

store._hybridLogCheckpoint.info.snapshotStartFlushedLogicalAddress = store.hlog.FlushedUntilAddress;
// If we are using a NullDevice then storage tier is not enabled and FlushedUntilAddress may be ReadOnlyAddress; get all records in memory.
store._hybridLogCheckpoint.info.snapshotStartFlushedLogicalAddress = store.hlog.IsNullDevice ? store.hlog.HeadAddress : store.hlog.FlushedUntilAddress;

long startPage = store.hlog.GetPage(store._hybridLogCheckpoint.info.snapshotStartFlushedLogicalAddress);
long endPage = store.hlog.GetPage(store._hybridLogCheckpoint.info.finalLogicalAddress);
if (store._hybridLogCheckpoint.info.finalLogicalAddress >
Expand All @@ -251,7 +253,8 @@ public override void GlobalBeforeEnteringState<Key, Value>(SystemState next, Tsa
break;
case Phase.PERSISTENCE_CALLBACK:
// Set actual FlushedUntil to the latest possible data in main log that is on disk
store._hybridLogCheckpoint.info.flushedLogicalAddress = store.hlog.FlushedUntilAddress;
// If we are using a NullDevice then storage tier is not enabled and FlushedUntilAddress may be ReadOnlyAddress; get all records in memory.
store._hybridLogCheckpoint.info.flushedLogicalAddress = store.hlog.IsNullDevice ? store.hlog.HeadAddress : store.hlog.FlushedUntilAddress;
base.GlobalBeforeEnteringState(next, store);
store._lastSnapshotCheckpoint = store._hybridLogCheckpoint.Transfer();
break;
Expand Down