Fix vector set index reads killing the RESP session - #2054
Merged
Tiago Nápoli (tiagonapoli) merged 1 commit intoAug 11, 2026
Merged
Conversation
MainSessionFunctions.CopyRespToWithInput enumerates the vector set
commands that read the index record, but lists only 8 of the 12 that
RespCommandExtensions.IsVectorSetCommand accepts. VCARD, VISMEMBER,
VLINKS and VRANDMEMBER fall through to the default arm and throw
GarnetException("Unsupported operation on input"). That exception
escapes ProcessMessages and disposes the whole RespServerSession, so
the client's next command fails with SocketClosed.
The read reaches that switch because VectorManager.ReadVectorIndex
forwards the caller's command into the read.
This is the cause of the frequent Garnet.test.vectorset CI failures:
InterruptedVectorSetDelete calls VISMEMBER, the session dies, and every
later command in the loop talks to a dead socket - VSIM being last is
where the RedisConnectionException surfaces.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3e0732df-259d-4ef2-b653-ff9fd3804334
Copilot started reviewing on behalf of
Tiago Nápoli (tiagonapoli)
August 11, 2026 01:16
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes RESP session termination when vector-set index reads use previously unhandled commands.
Changes:
- Handles VCARD, VISMEMBER, VLINKS, and VRANDMEMBER index reads.
- Prevents
GarnetExceptionfrom closing the client session.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ted Hart (TedHartMS)
approved these changes
Aug 11, 2026
kevin-montrose
approved these changes
Aug 11, 2026
Tiago Nápoli (tiagonapoli)
deleted the
tiagonapoli/fix-vectorset-index-read-session-kill
branch
August 11, 2026 14:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CopyRespToWithInputwas missingVCARD,VISMEMBER,VLINKSandVRANDMEMBER, so reading the index for those commands hit thedefault:arm and threwGarnetException("Unsupported operation on input")— which escapesProcessMessagesand disposes the wholeRespServerSession.That's the frequent
Garnet.test.vectorsetCI failure:InterruptedVectorSetDeletecallsVISMEMBER, the session dies, and the next command reportsSocketClosed(usually atVSIM).Repro matrix went from 6/10 containers failing to 0/600 iterations; full vectorset suite passes 391/391.