Fix non-string transactions in AOF - #2071
Merged
Merged
Conversation
…ions across different store types work
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns related Tsavorite session IDs so non-string transactional AOF entries replay correctly.
Changes:
- Adds optional session ID overrides.
- Shares IDs across string, object, unified, and vector sessions.
- Tracks active sessions by object identity.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ManageClientSessions.cs |
Adds ID overrides and identity-based tracking. |
ClientSession.cs |
Removes sessions by object reference. |
StorageSession.cs |
Assigns the main session ID to related sessions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Badrish Chandramouli (badrishc)
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AOF tracks transaction by client session id.
Unfortunately, unified and object sessions end up with different session ids than the "main" (ie. string) session.
This changes StorageSession to explicitly set session ids on object, unified, and vector (although vector does not participate in AOF) sessions.
This makes some small changes to revivification stat tracking, moving to a
ConcurrentDictionarykeyed by object identity rather than by session id.